-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL export queuing #2648
Merged
Merged
Fix SQL export queuing #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTA-Thinking
added
Bug
Bug bug bug.
Area-BulkExport
Area related to bulk export.
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
labels
Jun 8, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
fhibf
previously approved these changes
Jun 10, 2022
fhibf
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-BulkExport
Area related to bulk export.
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Bug
Bug bug bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where an export job couldn't be queued if it used a container that had be used before.
What was happening was the duplication detection was preventing jobs with the same container from being queued. Since the queued time was being hardcoded in the job definition the only source of difference between jobs with the same URL was the container. If the container wasn't specified it was set to a random GUID and jobs could be queued as normal. But if the container was specified only one job would be queued per unique URL. Any future requests with the same URL would match against the old job definition and not start a new job.
By adding a Till time that is set to the time the request was made it allows the jobs to be differentiated and multiple jobs can be made with the same container. The Queued time was implicitly acting as the Till time up to this point, but calling it out as an explicit parameter will make it more clear what it is used for and allow for it to be set as a query parameter in the future.
This only happened in SQL.
Related issues
Addresses [issue #].
Testing
Manual and existing E2E tests. This issue was found by the Export Job Tests.
FHIR Team Checklist
Semver Change (docs)
Patch