Added error message for RequestEntityTooLargeException in Export #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ityTooLargeException during export.
PTaladay
added
Bug
LTA-Thinking
reviewed
Sep 7, 2022
| @@ -232,6 +232,11 @@ public async Task ExecuteAsync(ExportJobRecord exportJobRecord, WeakETag weakETa | |||
| _exportJobRecord.FailureDetails = new JobFailureDetails(ex.Message, HttpStatusCode.BadRequest); | |||
| await CompleteJobAsync(OperationStatus.Failed, cancellationToken); | |||
| } | |||
| catch (RequestEntityTooLargeException) | |||
| { | |||
| _exportJobRecord.FailureDetails = new JobFailureDetails(Core.Resources.RequestEntityTooLargeExceptionDuringExport, HttpStatusCode.RequestEntityTooLarge); | |||
There was a problem hiding this comment.
We should be logging the error here like we do for the other exceptions.
There was a problem hiding this comment.
Thank you. I meant to add that in there.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LTA-Thinking
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now complete the JobReport as failed and return an actionable message instead of staying stuck as "accepted".
Related issues
Addresses [95042].
Testing
Updated Unit Tests.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)