Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent 2 iOS] Add ShadowTokensDemoController to demo app #1168

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Aug 16, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

ShadowTokensDemoController was added to the demo app to display shadow tokens. Each shadow is displayed on a CardView. The users can toggle between elevation shadow (Shadow 1) and border shadow (Shadow 2).

Verification

Before After
before_main Screen Shot 2022-08-18 at 11 23 15 AM
Shadow 1 Shadow 2
shadow1_1 shadow2_1
shadow1_2 shadow2_2
shadow1_1 shadow2_1
shadow1_2 shadow2_2

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm added the fluent2-colors 🎨 Changes targeting the fluent2-colors branch. label Aug 16, 2022
@laminesm laminesm requested a review from a team as a code owner August 16, 2022 22:52
@sophialee0416
Copy link
Contributor

Could we get dark mode screenshots?

@laminesm laminesm changed the title [Fluent 2 iOS] Added ShadowTokensDemoController to demo app [Fluent 2 iOS] Add ShadowTokensDemoController to demo app Aug 17, 2022
@laminesm
Copy link
Contributor Author

Could we get dark mode screenshots?

The description is updated with dark mode screenshots.

@laminesm laminesm force-pushed the laminemale/shadow-tokens-demo-controller branch from 980512c to b30d003 Compare August 18, 2022 18:20
@Saadnajmi
Copy link
Contributor

(Chiming in from the FURN side) Is there a way in the demo controller to see both shadows combined on one view? Not obvious to me there is one from the screenshots.

@laminesm
Copy link
Contributor Author

(Chiming in from the FURN side) Is there a way in the demo controller to see both shadows combined on one view? Not obvious to me there is one from the screenshots.

In this demo they are not combined. You can just toggle between the border shadows and the elevation shadows.

@laminesm laminesm merged commit f96f3cc into microsoft:fluent2-colors Aug 22, 2022
@laminesm laminesm deleted the laminemale/shadow-tokens-demo-controller branch August 22, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent2-colors 🎨 Changes targeting the fluent2-colors branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants