Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pill Button Bar section toggle not responding on RTL with large text #880

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Fix Pill Button Bar section toggle not responding on RTL with large text #880

merged 1 commit into from
Jan 26, 2022

Conversation

huwilkes
Copy link
Collaborator

@huwilkes huwilkes commented Jan 26, 2022 •
edited by ghost
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

The UISwitch we were using to toggle enabled/disabled for the sections of the PillButtonBar demo controller was getting squished by the label when RTL with large text. Increasing its resistance to compression fixed that.

Verification

(how the change was tested, including both manual and automated tests)

Before After
PillButton_Before PillButton_After

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@huwilkes
Fix section toggle not responding
626774e 
The UISwitch we were using to toggle enabled/disabled for the sections of the PillButtonBar demo controller was getting squished by the label when RTL with large text. Increasing its resistance to compression fixed that.
@huwilkes huwilkes requested a review from a team as a code owner January 26, 2022 00:52
@huwilkes huwilkes changed the title Fix section toggle not responding Fix Pill Button Bar section toggle not responding on RTL with large text Jan 26, 2022
@huwilkes huwilkes merged commit c14fcca into microsoft:main Jan 26, 2022
This was referenced Jan 26, 2022
Closed
Merged
Saadnajmi pushed a commit to Saadnajmi/fluentui-apple that referenced this pull request Feb 1, 2022
@huwilkes @Saadnajmi
Fix section toggle not responding (microsoft#880)
abe09fa 
The UISwitch we were using to toggle enabled/disabled for the sections of the PillButtonBar demo controller was getting squished by the label when RTL with large text. Increasing its resistance to compression fixed that.
@huwilkes huwilkes deleted the huwilkes-PillButtonSwitch branch February 4, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdeassis rdeassis rdeassis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huwilkes @rdeassis