Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SiteSettingsPanel] Additional information about Reset Settings is cropped. #1879

Closed
c0g1t8 opened this issue Apr 17, 2024 · 3 comments 路 Fixed by #1894
Closed

fix: [SiteSettingsPanel] Additional information about Reset Settings is cropped. #1879

c0g1t8 opened this issue Apr 17, 2024 · 3 comments 路 Fixed by #1894
Assignees
Labels
closed:done Work is finished

Comments

@c0g1t8
Copy link
Contributor

c0g1t8 commented Apr 17, 2024

馃悰 Bug Report

image

馃捇 Repro or Code Sample

Additional information about Reset Settings is cropped.

馃 Expected Behavior

Be able to see the addtional information.

馃槸 Current Behavior

Information is cropped.

馃拋 Possible Solution

Looks like another overflow setting issue.

馃敠 Context

Affects user experience with demo site.

馃實 Your Environment

  • OS & Device: PC and IPad
  • Browser: Microsoft Edge, Google Chrome, Apple Safari
  • .NET and Fluent UI Blazor library Version: 8.0.4 and 4.6.1
@c0g1t8
Copy link
Contributor Author

c0g1t8 commented Apr 17, 2024

Can you assign to me?

@vnbaaij vnbaaij added the status:in-progress Work is in progress label Apr 17, 2024
@c0g1t8
Copy link
Contributor Author

c0g1t8 commented Apr 18, 2024

I was able to 'uncrop' the information provided in the FluentPopover using the browser debugger tools. I found two methods.

  1. Setting of the CSS position attribute of the underlying fluent-anchored-region web component to fixed. This attribute is set directly in the rendered DOM. It can't be overridden using CSS only. It would require changing The downside was that you could not scroll if the information extended beyond the bottom of the screen.

    One way of achieving this would be set the FixedPlacement parameter of the FLuentAnchoredRegion. This would necessitate exposing an new parameter for FluentPopover.

  2. Removing the 'overflow-y' parameter from the fluent-dialog web component which contains the information. The behaviour would be unchanged with the exception that all the information would be visible.

    Though I prefer this behaviour, I don't believe making this change to FluentDialog is worthwhile to address this one issue. I could likely achieve this with some isolated JavaScript in SiteSettingsPanel.

Is submitting a PR based on Option 1 above worthwhile? FixedPlacement would default to false to ensure backward compatibility.

@vnbaaij
Copy link
Collaborator

vnbaaij commented Apr 18, 2024

I think we need the parameter sooner or later anyway. Let's expose it on the Popover

c0g1t8 added a commit to c0g1t8/fluentui-blazor that referenced this issue Apr 18, 2024
vnbaaij pushed a commit that referenced this issue Apr 18, 2024
* adds FixedPlacement parameter to FluentPopover

* fixes SiteSettingsPanel #1879
vnbaaij pushed a commit that referenced this issue Apr 23, 2024
* adds FixedPlacement parameter to FluentPopover

* fixes SiteSettingsPanel #1879
@vnbaaij vnbaaij added closed:done Work is finished and removed status:in-progress Work is in progress labels Apr 25, 2024
vnbaaij pushed a commit that referenced this issue Apr 29, 2024
* adds FixedPlacement parameter to FluentPopover

* fixes SiteSettingsPanel #1879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:done Work is finished
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants