Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SortableList] Adding Properties FromListId and ToListId #2385

Merged
merged 11 commits into from
Jul 16, 2024

Conversation

RReventlov
Copy link
Contributor

Pull Request

📖 Description

The current implementation of FluentSortableListEventArgs does not allow one to determine from which list onto which list the item was dragged and then dropped. By providing two additional properties, FromId and ToId the developer would be able to determine which lists were involved.

🎫 Issues

#2376

👩‍💻 Reviewer Notes

I am very unsure about the tests I wrote, especially FluentSortableList_OnUpdate.

📑 Test Plan

I added tests to FluentSortableListTests.razor. I don't think I did emply any unique strategies.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@RReventlov
Copy link
Contributor Author

@microsoft-github-policy-service agree

@RReventlov
Copy link
Contributor Author

Regarding the I have updated the project documentation to reflect my changes point, I have added a DemoLogger to the SortableListMoveBetweenLists.razor Page. I'm not sure if that counts as updated the project documentation.

@dvoituron dvoituron merged commit f8f0e5a into microsoft:dev Jul 16, 2024
4 checks passed
@RReventlov RReventlov deleted the feat/fluentsearchablelist branch July 16, 2024 08:56
@vnbaaij vnbaaij added this to the v4.9.2 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants