-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SortableList] Adding Properties FromListId and ToListId #2385
Merged
dvoituron
merged 11 commits into
microsoft:dev
from
RReventlov:feat/fluentsearchablelist
Jul 16, 2024
Merged
[SortableList] Adding Properties FromListId and ToListId #2385
dvoituron
merged 11 commits into
microsoft:dev
from
RReventlov:feat/fluentsearchablelist
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The swapping is still handled differently (getting the list through the ids) than before.
@microsoft-github-policy-service agree |
Regarding the I have updated the project documentation to reflect my changes point, I have added a DemoLogger to the |
dvoituron
requested changes
Jul 16, 2024
tests/Core/Microsoft.FluentUI.AspNetCore.Components.Tests.csproj
Outdated
Show resolved
Hide resolved
dvoituron
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The current implementation of
FluentSortableListEventArgs
does not allow one to determine from which list onto which list the item was dragged and then dropped. By providing two additional properties,FromId
andToId
the developer would be able to determine which lists were involved.🎫 Issues
#2376
👩💻 Reviewer Notes
I am very unsure about the tests I wrote, especially
FluentSortableList_OnUpdate
.📑 Test Plan
I added tests to
FluentSortableListTests.razor
. I don't think I did emply any unique strategies.✅ Checklist
General
Component-specific
⏭ Next Steps