[Overflow] Add Fixed parameter
#2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.6%
|
|
In the after gif, I see the "more" button doesn't stay visible. Was the intentional? Also, is the space available for the first item shrinking with the column? I want to be able to add CSS so that text for the first item ends with an ellipsis when required. You can see that effect in the first gif here: #2391 |
|
I've not done aby attempt at styling what is shown in the overflow/grid. Getting the effect as shown in your gif will probably be a bit more complex. I need to dive a bit deepee on how things are being rendered with this new set up. |
I can work on that tomorrow, based on a new PR. |
dvoituron
approved these changes
Jul 17, 2024
@JamesNK Done in PR #2401 |
vnbaaij
added a commit
that referenced
this pull request
Jul 18, 2024
* Fix typo Fix two typos I spotted in #2393. * Fix typo Fix typo in PR template. --------- Co-authored-by: Vincent Baaij <vnbaaij@outlook.com>
|
That looks great. I'll try it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixedparameter toFluentOverflowItemThe script used to determine which items overflow actually already accounted for this...
By supplying a fixed attribute to an item, it will be excluded from the calculations (we already use that internally with the AppBar). We just did not expose this in any way in the FluentOverflowItem as a parameter.
Before
After