chore: improve dist size for N* #15331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 39d8aa5:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0af4f308c6f7da6a6c5e3796696e92d451a73919 (build) |
layershifter
commented
Jan 4, 2021
|
|
||
| task( | ||
| 'bundle:package:types', | ||
| series('bundle:package:types:tsc', 'bundle:package:types:copy', 'bundle:package:types:clean'), |
There was a problem hiding this comment.
Types should exist only under es directory, this will remove temporary dts directory after build.
layershifter
commented
Jan 4, 2021
| .pipe(dest(paths.packageDist(packageName, 'commonjs'))), | ||
| ); | ||
|
|
||
| task('bundle:package:es', () => | ||
| src(componentsSrc) | ||
| .pipe(sourcemaps.init()) | ||
| .pipe(babel({ caller: { useESModules: true } } as any)) | ||
| .pipe(sourcemaps.write('.')) | ||
| .pipe(sourcemaps.write()) |
There was a problem hiding this comment.
Sourcemaps will be written inline, it saves from sourcemaps warnings.
miroslavstastny
approved these changes
Jan 4, 2021
YuanboXue-Amber
added a commit
that referenced
this pull request
Jan 19, 2021
This reverts commit 6d4e387.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warnings about sourcemaps
The basic Webpack setup was screaming about missing sourcemaps, now there are inlined so there it's not an issue anymore.
cleanup build
With @miroslavstastny we mentioned that artifacts published to NPM are too heavy.
distfolder was not cleaned up properly (/*does not work at least on Windows) so I was publishingprocessedIconsfolder that was removed a decade agodtsfolder was also published however it's not required at allThe result is 31MB => 14MB on published artifacts for
@fluentui/react-northstar, this should speed up install of packages on CodeSandbox.