Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-components] fix elevated corner radius application in dialog #15752

Merged
merged 2 commits into from
Oct 28, 2020
Merged

[web-components] fix elevated corner radius application in dialog #15752

merged 2 commits into from
Oct 28, 2020

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@chrisdholt chrisdholt self-assigned this Oct 28, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c033e3:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 863 830 5000
BaseButtonCompat mount 912 936 5000
Breadcrumb mount 42352 41977 5000
Checkbox mount 1544 1575 5000
CheckboxBase mount 1372 1335 5000
ChoiceGroup mount 4844 4812 5000
ComboBox mount 944 985 1000
CommandBar mount 10041 9923 1000
ContextualMenu mount 5948 5970 1000
DefaultButtonCompat mount 1161 1166 5000
DetailsRow mount 3693 3662 5000
DetailsRowFast mount 3722 3726 5000
DetailsRowNoStyles mount 3465 3404 5000
Dialog mount 1521 1525 1000
DocumentCardTitle mount 1768 1757 1000
Dropdown mount 3452 3445 5000
FocusTrapZone mount 1889 1789 5000
FocusZone mount 1786 1791 5000
IconButtonCompat mount 1810 1778 5000
Label mount 361 336 5000
Layer mount 1775 1835 5000
Link mount 472 498 5000
MenuButtonCompat mount 1504 1531 5000
MessageBar mount 1991 1999 5000
Nav mount 3352 3306 1000
OverflowSet mount 1000 1027 5000
Panel mount 1451 1446 1000
Persona mount 852 837 1000
Pivot mount 1394 1392 1000
PrimaryButtonCompat mount 1309 1285 5000
Rating mount 7864 7815 5000
SearchBox mount 1360 1356 5000
Shimmer mount 2625 2625 5000
Slider mount 1934 1919 5000
SpinButton mount 5078 5132 5000
Spinner mount 415 408 5000
SplitButtonCompat mount 3166 3247 5000
Stack mount 518 527 5000
StackWithIntrinsicChildren mount 1629 1601 5000
StackWithTextChildren mount 4979 4963 5000
SwatchColorPicker mount 10338 10639 5000
TagPicker mount 2822 2800 5000
TeachingBubble mount 11597 11562 5000
Text mount 445 428 5000
TextField mount 1400 1412 5000
ThemeProvider mount 1934 1963 5000
ThemeProvider virtual-rerender 636 645 5000
Toggle mount 796 825 5000
button mount 547 547 5000
buttonNative mount 107 106 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.51 0.94:1 2000 951
🦄 Button.Fluent 0.13 0.26 0.5:1 5000 647
🔧 Checkbox.Fluent 0.67 0.37 1.81:1 1000 669
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 848
🔧 Dropdown.Fluent 2.94 0.44 6.68:1 1000 2935
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 747
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 441
🔧 Slider.Fluent 1.6 0.45 3.56:1 1000 1595
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 404
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 615

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AnimationMinimalPerf.default 450 417 1.08:1
AttachmentMinimalPerf.default 186 173 1.08:1
ChatDuplicateMessagesPerf.default 458 426 1.08:1
AttachmentSlotsPerf.default 1246 1167 1.07:1
AvatarMinimalPerf.default 519 496 1.05:1
BoxMinimalPerf.default 413 395 1.05:1
LayoutMinimalPerf.default 454 432 1.05:1
LoaderMinimalPerf.default 804 769 1.05:1
IconMinimalPerf.default 741 703 1.05:1
Dialog.Fluent 848 811 1.05:1
ButtonOverridesMissPerf.default 1785 1711 1.04:1
ChatMinimalPerf.default 661 636 1.04:1
DialogMinimalPerf.default 855 826 1.04:1
ListMinimalPerf.default 546 526 1.04:1
MenuButtonMinimalPerf.default 1702 1642 1.04:1
StatusMinimalPerf.default 831 799 1.04:1
TextMinimalPerf.default 411 395 1.04:1
TextAreaMinimalPerf.default 579 556 1.04:1
VideoMinimalPerf.default 729 701 1.04:1
AccordionMinimalPerf.default 183 177 1.03:1
ButtonUseCssPerf.default 881 854 1.03:1
CardMinimalPerf.default 640 621 1.03:1
CarouselMinimalPerf.default 486 472 1.03:1
ChatWithPopoverPerf.default 498 483 1.03:1
FlexMinimalPerf.default 339 329 1.03:1
ImageMinimalPerf.default 442 428 1.03:1
SegmentMinimalPerf.default 407 396 1.03:1
SkeletonMinimalPerf.default 483 468 1.03:1
TableMinimalPerf.default 465 451 1.03:1
Checkbox.Fluent 669 650 1.03:1
Tooltip.Fluent 615 596 1.03:1
DropdownMinimalPerf.default 2972 2917 1.02:1
EmbedMinimalPerf.default 2092 2042 1.02:1
InputMinimalPerf.default 1350 1324 1.02:1
PopupMinimalPerf.default 730 715 1.02:1
RefMinimalPerf.default 240 236 1.02:1
TooltipMinimalPerf.default 851 834 1.02:1
Button.Fluent 647 632 1.02:1
Dropdown.Fluent 2935 2886 1.02:1
Text.Fluent 404 396 1.02:1
AlertMinimalPerf.default 334 330 1.01:1
DividerMinimalPerf.default 423 420 1.01:1
HeaderSlotsPerf.default 866 856 1.01:1
MenuMinimalPerf.default 943 932 1.01:1
PortalMinimalPerf.default 165 164 1.01:1
ProviderMinimalPerf.default 1032 1018 1.01:1
ReactionMinimalPerf.default 460 454 1.01:1
SplitButtonMinimalPerf.default 3949 3912 1.01:1
TableManyItemsPerf.default 2392 2379 1.01:1
ToolbarMinimalPerf.default 1013 1005 1.01:1
Avatar.Fluent 951 939 1.01:1
ButtonUseCssNestingPerf.default 1117 1112 1:1
CheckboxMinimalPerf.default 2938 2949 1:1
ItemLayoutMinimalPerf.default 1393 1399 1:1
ListCommonPerf.default 705 705 1:1
ListNestedPerf.default 612 613 1:1
ListWith60ListItems.default 980 980 1:1
SliderMinimalPerf.default 1589 1589 1:1
CustomToolbarPrototype.default 3946 3933 1:1
Icon.Fluent 747 747 1:1
Image.Fluent 441 443 1:1
DropdownManyItemsPerf.default 805 815 0.99:1
GridMinimalPerf.default 400 404 0.99:1
RadioGroupMinimalPerf.default 481 485 0.99:1
Slider.Fluent 1595 1610 0.99:1
FormMinimalPerf.default 465 476 0.98:1
ProviderMergeThemesPerf.default 2016 2056 0.98:1
ButtonSlotsPerf.default 662 679 0.97:1
HeaderMinimalPerf.default 421 435 0.97:1
TreeMinimalPerf.default 931 964 0.97:1
TreeWith60ListItems.default 203 210 0.97:1
ButtonMinimalPerf.default 190 197 0.96:1
LabelMinimalPerf.default 462 480 0.96:1

@size-auditor
Copy link

size-auditor bot commented Oct 28, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1b963c69f47a8eb69e4b79319fcfe060a9d2749c (build)

@chrisdholt chrisdholt merged commit a04560f into microsoft:master Oct 28, 2020
@chrisdholt chrisdholt deleted the users/chhol/fix-elevation-multiplier-dialog branch October 28, 2020 23:33
@msft-github-bot
Copy link
Contributor

🎉@fluentui/web-components@v0.7.0 has been released which incorporates this pull request.:tada:

Handy links:

SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 23, 2020
@chrisdholt
[web-components] fix elevated corner radius application in dialog (mi…
05a1a6f 
…crosoft#15752)

* ensure elevated corner radius is applied to dialog

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bheston bheston bheston approved these changes

Assignees

@chrisdholt chrisdholt

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisdholt @msft-github-bot @bheston