Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DetailsList: Adding focusZoneProps prop to IDetailsListProps and IDetailsRowBaseProps #19404

Merged
merged 6 commits into from
Aug 27, 2021
Merged

DetailsList: Adding focusZoneProps prop to IDetailsListProps and IDetailsRowBaseProps #19404

merged 6 commits into from
Aug 27, 2021

Conversation

richard-einfinity
Copy link
Contributor

@richard-einfinity richard-einfinity commented Aug 16, 2021 •
edited by khmakoto
Loading

Pull request checklist

Description of changes

Add focusZoneProps to IDetailsListProps and IDetailsRowBaseProps

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 16, 2021 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 997099c28f27cc2979f984d0c0b06c97f84a4aac

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 16, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a68c624:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 16, 2021 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-ShimmeredDetailsList 220.34 kB 220.565 kB ExceedsBaseline     225 bytes
office-ui-fabric-react fluentui-react-DetailsList 209.733 kB 209.956 kB ExceedsBaseline     223 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 997099c28f27cc2979f984d0c0b06c97f84a4aac (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 16, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 924 908 5000
BaseButton mount 933 931 5000
Breadcrumb mount 2644 2640 1000
ButtonNext mount 445 424 5000
Checkbox mount 1558 1533 5000
CheckboxBase mount 1295 1274 5000
ChoiceGroup mount 4803 4796 5000
ComboBox mount 982 1053 1000
CommandBar mount 10358 10285 1000
ContextualMenu mount 6431 6254 1000
DefaultButton mount 1165 1119 5000
DetailsRow mount 3831 3806 5000
DetailsRowFast mount 3866 3746 5000
DetailsRowNoStyles mount 3570 3539 5000
Dialog mount 2168 2183 1000
DocumentCardTitle mount 143 155 1000
Dropdown mount 3290 3295 5000
FluentProviderNext mount 7685 7612 5000
FocusTrapZone mount 1881 1825 5000
FocusZone mount 1848 1838 5000
IconButton mount 1754 1759 5000
Label mount 339 341 5000
Layer mount 1799 1751 5000
Link mount 466 469 5000
MakeStyles mount 1865 1842 50000
MenuButton mount 1493 1463 5000
MessageBar mount 2026 2014 5000
Nav mount 3254 3297 1000
OverflowSet mount 1136 1115 5000
Panel mount 2097 2123 1000
Persona mount 839 832 1000
Pivot mount 1405 1423 1000
PrimaryButton mount 1284 1316 5000
Rating mount 7752 7681 5000
SearchBox mount 1330 1318 5000
Shimmer mount 2483 2561 5000
Slider mount 1942 1964 5000
SpinButton mount 5067 5043 5000
Spinner mount 433 438 5000
SplitButton mount 3219 3204 5000
Stack mount 495 532 5000
StackWithIntrinsicChildren mount 1648 1643 5000
StackWithTextChildren mount 4579 4696 5000
SwatchColorPicker mount 10429 10600 5000
Tabs mount 1406 1428 1000
TagPicker mount 2665 2581 5000
TeachingBubble mount 11977 11996 5000
Text mount 429 455 5000
TextField mount 1378 1363 5000
ThemeProvider mount 1199 1195 5000
ThemeProvider virtual-rerender 612 619 5000
Toggle mount 797 790 5000
buttonNative mount 118 125 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 188 164 1.15:1
AttachmentMinimalPerf.default 174 160 1.09:1
LabelMinimalPerf.default 411 376 1.09:1
ListMinimalPerf.default 537 504 1.07:1
ImageMinimalPerf.default 391 368 1.06:1
ListNestedPerf.default 578 546 1.06:1
ButtonMinimalPerf.default 177 169 1.05:1
ChatMinimalPerf.default 669 637 1.05:1
ChatWithPopoverPerf.default 374 356 1.05:1
CarouselMinimalPerf.default 480 461 1.04:1
HeaderMinimalPerf.default 372 358 1.04:1
TreeMinimalPerf.default 815 781 1.04:1
ChatDuplicateMessagesPerf.default 302 293 1.03:1
DialogMinimalPerf.default 773 752 1.03:1
GridMinimalPerf.default 343 332 1.03:1
LoaderMinimalPerf.default 709 690 1.03:1
AnimationMinimalPerf.default 427 420 1.02:1
AttachmentSlotsPerf.default 1089 1068 1.02:1
BoxMinimalPerf.default 352 344 1.02:1
CardMinimalPerf.default 567 554 1.02:1
DropdownManyItemsPerf.default 693 681 1.02:1
InputMinimalPerf.default 1326 1294 1.02:1
LayoutMinimalPerf.default 367 360 1.02:1
ListCommonPerf.default 629 618 1.02:1
TableManyItemsPerf.default 1912 1873 1.02:1
AlertMinimalPerf.default 272 269 1.01:1
CheckboxMinimalPerf.default 2751 2727 1.01:1
DropdownMinimalPerf.default 3232 3198 1.01:1
MenuMinimalPerf.default 836 826 1.01:1
TextAreaMinimalPerf.default 491 487 1.01:1
CustomToolbarPrototype.default 4075 4039 1.01:1
TooltipMinimalPerf.default 1024 1013 1.01:1
DividerMinimalPerf.default 360 360 1:1
ItemLayoutMinimalPerf.default 1214 1211 1:1
ProviderMergeThemesPerf.default 1739 1736 1:1
RadioGroupMinimalPerf.default 455 456 1:1
SplitButtonMinimalPerf.default 4231 4218 1:1
IconMinimalPerf.default 645 646 1:1
TableMinimalPerf.default 403 405 1:1
AccordionMinimalPerf.default 157 159 0.99:1
DatepickerMinimalPerf.default 5546 5593 0.99:1
EmbedMinimalPerf.default 4278 4302 0.99:1
PopupMinimalPerf.default 594 600 0.99:1
ProviderMinimalPerf.default 1074 1082 0.99:1
SliderMinimalPerf.default 1637 1649 0.99:1
StatusMinimalPerf.default 680 685 0.99:1
ToolbarMinimalPerf.default 922 927 0.99:1
VideoMinimalPerf.default 620 628 0.99:1
AvatarMinimalPerf.default 189 193 0.98:1
ButtonSlotsPerf.default 554 566 0.98:1
RosterPerf.default 1154 1181 0.98:1
SegmentMinimalPerf.default 336 342 0.98:1
TextMinimalPerf.default 348 354 0.98:1
ButtonOverridesMissPerf.default 1725 1785 0.97:1
HeaderSlotsPerf.default 751 772 0.97:1
SkeletonMinimalPerf.default 345 355 0.97:1
FormMinimalPerf.default 385 400 0.96:1
MenuButtonMinimalPerf.default 1618 1681 0.96:1
PortalMinimalPerf.default 175 183 0.96:1
ReactionMinimalPerf.default 365 379 0.96:1
ListWith60ListItems.default 639 673 0.95:1
RefMinimalPerf.default 237 250 0.95:1
FlexMinimalPerf.default 285 305 0.93:1

@khmakoto khmakoto changed the title Feature/detailslistfocuszone DetailsList: Adding focusZoneProps prop to IDetailsListProps and IDetailsRowBaseProps Aug 25, 2021
@richard-einfinity
Copy link
Contributor Author

@khmakoto all comments and conflicts resolved 👍🏻😊

@richard-einfinity @khmakoto
Update packages/react/src/components/DetailsList/DetailsRow.types.ts
a68c624 
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
@khmakoto khmakoto enabled auto-merge (squash) August 27, 2021 23:36
@khmakoto khmakoto merged commit b9845c2 into microsoft:master Aug 27, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tabs@v1.0.0-beta.148 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-monaco-editor@v1.2.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot msft-fluent-ui-bot mentioned this pull request Aug 30, 2021
Closed
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme-samples@v8.2.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-date-time@v8.1.59 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react@v8.30.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-charting@v5.3.32 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-cards@v0.200.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-experiments@v8.3.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-docsite-components@v8.3.20 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/azure-themes@v8.1.60 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon ThomasMichon is a code owner

Assignees

@smhigley smhigley

Labels
Component: DetailsList PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DetailsList: can customize "shouldEnterInnerZone" property of list's FocusZone
5 participants
@richard-einfinity @fabricteam @msft-fluent-ui-bot @khmakoto @smhigley