Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2 more exports to @fluentui/theme for v7 backwards compatibility purposes. #22043

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

dzearing
Copy link
Member

Found 2 more imports from @uifabric/fluent-theme which won't work with the latest @fluentui/theme due to missing exports.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 256b4dd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 10, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a3678bcb364dc53238c3496697198355945556e3 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against a3678bcb364dc53238c3496697198355945556e3

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 912 927 5000
Breadcrumb mount 2736 2735 1000
Checkbox mount 1529 1542 5000
CheckboxBase mount 1328 1309 5000
ChoiceGroup mount 4851 4902 5000
ComboBox mount 1016 1023 1000
CommandBar mount 10599 10731 1000
ContextualMenu mount 12200 12256 1000
DefaultButton mount 1160 1178 5000
DetailsRow mount 3820 3956 5000
DetailsRowFast mount 3925 3928 5000
DetailsRowNoStyles mount 3697 3770 5000
Dialog mount 2252 2246 1000
DocumentCardTitle mount 166 174 1000
Dropdown mount 3429 3357 5000
FocusTrapZone mount 1809 1869 5000
FocusZone mount 1834 1873 5000
IconButton mount 1801 1812 5000
Label mount 364 350 5000
Layer mount 3100 3033 5000
Link mount 484 466 5000
MenuButton mount 1560 1560 5000
MessageBar mount 2172 2162 5000
Nav mount 3365 3451 1000
OverflowSet mount 1109 1136 5000
Panel mount 2203 2182 1000
Persona mount 884 851 1000
Pivot mount 1494 1454 1000
PrimaryButton mount 1355 1334 5000
Rating mount 7897 7998 5000
SearchBox mount 1313 1345 5000
Shimmer mount 2534 2551 5000
Slider mount 1967 2014 5000
SpinButton mount 5582 5146 5000
Spinner mount 467 444 5000
SplitButton mount 3236 3232 5000
Stack mount 551 532 5000
StackWithIntrinsicChildren mount 2306 2380 5000
StackWithTextChildren mount 5368 5420 5000
SwatchColorPicker mount 11858 12092 5000
TagPicker mount 2849 2807 5000
TeachingBubble mount 101954 102354 5000
Text mount 464 436 5000
TextField mount 1479 1448 5000
ThemeProvider mount 1206 1223 5000
ThemeProvider virtual-rerender 641 692 5000
ThemeProvider virtual-rerender-with-unmount 1896 1938 5000
Toggle mount 804 829 5000
buttonNative mount 133 140 5000

@ecraig12345 ecraig12345 merged commit 7bc5644 into microsoft:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants