Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-tabs: Added content and icon styles to subtle appearance #22439

Merged

Conversation

GeoffCoxMSFT
Copy link
Member

Current Behavior

Subtle tab content and icon not set.
This was due to moving styles into transparent that previously were on base.

New Behavior

Subtle tab content and icon styles applied per figma

Related Issue(s)

Related to #22336

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8606f9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
176.089 kB
49.113 kB
react-components
react-components: FluentProvider & webLightTheme
32.601 kB
10.668 kB
🤖 This report was generated against 69bcdf2f52fe6a8bf7d5f7ca71be74d753202356

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1043 1033 5000
Button mount 623 620 5000
FluentProvider mount 2070 2060 5000
FluentProviderWithTheme mount 299 299 10
FluentProviderWithTheme virtual-rerender 255 255 10
FluentProviderWithTheme virtual-rerender-with-unmount 339 358 10
MakeStyles mount 1796 1772 50000

@size-auditor
Copy link

size-auditor bot commented Apr 9, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 69bcdf2f52fe6a8bf7d5f7ca71be74d753202356 (build)

@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) April 11, 2022 16:25
@GeoffCoxMSFT GeoffCoxMSFT merged commit 72fa867 into microsoft:master Apr 11, 2022
@GeoffCoxMSFT GeoffCoxMSFT deleted the tabs-fix-high-contrast-subtle branch April 18, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants