PeoplePicker: Improved keyboard support #2372
Conversation
…size, made suggested contact list properly focus first suggestion.
kristoferbrown
requested review from
gokunymbus,
dzearing,
mikewheaton,
micahgodbolt,
betrue-final-final,
joschect and
MLoughry
|
The second issue is fixed, testing with Narrator + Edge, but I can't get the "Load all results" footer to appear. |
|
Alright you can also get to "Load all results" but you can't get to "Top 10 results" after you tap "Load all results" |
|
Ok, I talked to to Kris, and Top 10 results is just a label. Please make that label color instead of link color "neutralPrimary" |
…/kristoferbrown/office-ui-fabric-react into v-krbrow/peoplepicker-owa-review
|
@betrue-final-final, I removed the Top 10 element since it wasn't really represented in the XD file and was causing this ambiguity. |
| @@ -25,6 +25,7 @@ $Callout-smallbeak-slant-width: 16px; | |||
| @include ms-drop-shadow(0,0, 5px, 0px); | |||
| position: absolute; | |||
| box-sizing: border-box; | |||
| border: 1px solid $ms-color-neutralLight; | |||
There was a problem hiding this comment.
As much as I want this change to happen, this isn't the right PR for it and I'd recommend splitting it out into it's own PR in an effort to keep PRs Single Responsibility.
There was a problem hiding this comment.
The border was originally removed in an update to the people picker's callout, so I didn't think it was a big deal to add it back in another update to the people picker's callout. You're right though, I'll pull it out here and start a new PR.
There was a problem hiding this comment.
Pull request checklist
$ npm run changeDescription of changes
Allows the 'Load all Results' button to get keyboard focus.
Prevents keyboard focus from skipping the first item in the suggested contacts list.
Also, decreases font size of Loading and Load all Results elements.
Focus areas to test
The people picker suggestion list.