Theme designer: minor fixes #23741
Merged
Theme designer: minor fixes #23741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4b0a816:
|
📊 Bundle size report🤖 This report was generated against 267e10e8adb913ba4151054d5b805ac1fe513e35 |
micahgodbolt
approved these changes
Jun 27, 2022
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 267e10e8adb913ba4151054d5b805ac1fe513e35 (build) |
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
* export to codesandbox opens new page * update defaults * extracting string constants from render * add debouncing to keycolor * extend debounce to all entries in the form * remove slider value * Update ExportLink.tsx
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 29, 2022
…ect-amout-of-items * master: chore: improve error message in useIsSSR() (microsoft#23750) fix: Codesandbox exports should use ^9.0.0 (microsoft#23764) applying package updates Update BadgeColor.stories.tsx (microsoft#23762) chore(react-avatar): Adding unit and vr tests for AvatarGroup (microsoft#23549) docs(react-avatar): Adding readme and migration guide for AvatarGroup (microsoft#23758) update deps after 9.0.1 release (microsoft#23756) applying package updates fix: Use caret dependency range for Griffel (microsoft#23754) Theme designer: minor fixes (microsoft#23741) fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the header on the toolbar the Preview Light/Dark Theme in CodeSandbox now opens a new tab rather than navigating away from the app (as suggested by Geoff). ColorTokens.tsx has an updated storybook entry. Extracted out the string constants from within the render method of ExportLink.tsx (as suggested by Geoff). Added a debounce to all inputs in the edit tab of the sidebar (the color pickers & the sliders).
To-do list: https://github.com/microsoft/fluentui/projects/30?fullscreen=true