Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dependency mismatch after 9.0.0 release #23752

Merged
merged 2 commits into from
Jun 28, 2022
Merged

fix: Dependency mismatch after 9.0.0 release #23752

merged 2 commits into from
Jun 28, 2022

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Jun 28, 2022 •
edited
Loading

Fixing a known issue with our releases

@github-actions github-actions bot added this to the June Project Cycle Q2 2022 milestone Jun 28, 2022
@ling1726 ling1726 marked this pull request as ready for review June 28, 2022 15:31
@ling1726 ling1726 requested review from a team as code owners June 28, 2022 15:31
@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against cd739a5

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd739a5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jun 28, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d8997f68c68e6c71a09f9db87ec54aff9cd9a651 (build)

@ling1726 ling1726 enabled auto-merge (squash) June 28, 2022 15:47
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against d8997f68c68e6c71a09f9db87ec54aff9cd9a651

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 166 153 1.08:1
PortalMinimalPerf.default 174 163 1.07:1
AccordionMinimalPerf.default 140 132 1.06:1
BoxMinimalPerf.default 336 316 1.06:1
TreeWith60ListItems.default 160 151 1.06:1
AlertMinimalPerf.default 266 254 1.05:1
ListMinimalPerf.default 519 494 1.05:1
ReactionMinimalPerf.default 371 354 1.05:1
AttachmentMinimalPerf.default 151 145 1.04:1
AvatarMinimalPerf.default 183 176 1.04:1
HeaderSlotsPerf.default 767 737 1.04:1
RefMinimalPerf.default 235 226 1.04:1
TableMinimalPerf.default 391 377 1.04:1
LoaderMinimalPerf.default 687 668 1.03:1
TextAreaMinimalPerf.default 487 475 1.03:1
AnimationMinimalPerf.default 539 531 1.02:1
FormMinimalPerf.default 400 392 1.02:1
GridMinimalPerf.default 331 326 1.02:1
PopupMinimalPerf.default 622 607 1.02:1
CustomToolbarPrototype.default 2740 2696 1.02:1
AttachmentSlotsPerf.default 1074 1066 1.01:1
CardMinimalPerf.default 550 546 1.01:1
ChatMinimalPerf.default 729 720 1.01:1
ChatWithPopoverPerf.default 363 359 1.01:1
DialogMinimalPerf.default 766 759 1.01:1
DropdownManyItemsPerf.default 665 661 1.01:1
EmbedMinimalPerf.default 4107 4061 1.01:1
HeaderMinimalPerf.default 348 344 1.01:1
LabelMinimalPerf.default 375 370 1.01:1
MenuMinimalPerf.default 834 822 1.01:1
MenuButtonMinimalPerf.default 1687 1677 1.01:1
ProviderMinimalPerf.default 396 393 1.01:1
SegmentMinimalPerf.default 337 333 1.01:1
StatusMinimalPerf.default 659 655 1.01:1
TooltipMinimalPerf.default 1117 1104 1.01:1
ButtonOverridesMissPerf.default 1467 1472 1:1
CarouselMinimalPerf.default 462 462 1:1
ChatDuplicateMessagesPerf.default 274 275 1:1
CheckboxMinimalPerf.default 2697 2688 1:1
DropdownMinimalPerf.default 3132 3132 1:1
InputMinimalPerf.default 1287 1287 1:1
ItemLayoutMinimalPerf.default 1178 1173 1:1
ListNestedPerf.default 528 526 1:1
ProviderMergeThemesPerf.default 1259 1256 1:1
RadioGroupMinimalPerf.default 431 433 1:1
SplitButtonMinimalPerf.default 4310 4293 1:1
TableManyItemsPerf.default 1900 1891 1:1
ToolbarMinimalPerf.default 933 933 1:1
VideoMinimalPerf.default 636 634 1:1
ButtonSlotsPerf.default 527 531 0.99:1
DatepickerMinimalPerf.default 5559 5630 0.99:1
DividerMinimalPerf.default 335 338 0.99:1
FlexMinimalPerf.default 277 279 0.99:1
LayoutMinimalPerf.default 343 345 0.99:1
ListCommonPerf.default 622 628 0.99:1
RosterPerf.default 1082 1093 0.99:1
TextMinimalPerf.default 330 335 0.99:1
ImageMinimalPerf.default 352 360 0.98:1
SkeletonMinimalPerf.default 337 345 0.98:1
SliderMinimalPerf.default 1643 1675 0.98:1
IconMinimalPerf.default 587 613 0.96:1
TreeMinimalPerf.default 777 807 0.96:1
ListWith60ListItems.default 589 620 0.95:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 976 925 5000
Breadcrumb mount 2839 2933 1000
Checkbox mount 1545 1559 5000
CheckboxBase mount 1383 1298 5000
ChoiceGroup mount 4957 4972 5000
ComboBox mount 975 1017 1000
CommandBar mount 11282 11088 1000
ContextualMenu mount 13360 14255 1000
DefaultButton mount 1227 1167 5000
DetailsRow mount 4088 4001 5000
DetailsRowFast mount 4112 4072 5000
DetailsRowNoStyles mount 3883 3878 5000
Dialog mount 3011 3038 1000
DocumentCardTitle mount 179 198 1000
Dropdown mount 3480 3537 5000
FocusTrapZone mount 1930 2035 5000
FocusZone mount 1895 1933 5000
IconButton mount 1865 1873 5000
Label mount 371 385 5000
Layer mount 3083 3032 5000
Link mount 484 460 5000
MenuButton mount 1521 1517 5000
MessageBar mount 2236 2102 5000
Nav mount 3414 3441 1000
OverflowSet mount 1096 1134 5000
Panel mount 2271 2399 1000
Persona mount 1038 1105 1000
Pivot mount 1480 1497 1000
PrimaryButton mount 1343 1383 5000
Rating mount 7935 7941 5000
SearchBox mount 1377 1376 5000
Shimmer mount 2780 2562 5000
Slider mount 2022 1981 5000
SpinButton mount 5169 5334 5000
Spinner mount 436 442 5000
SplitButton mount 3347 3292 5000
Stack mount 525 529 5000
StackWithIntrinsicChildren mount 2454 2403 5000
StackWithTextChildren mount 5485 5400 5000
SwatchColorPicker mount 12078 12094 5000
TagPicker mount 2839 2785 5000
TeachingBubble mount 100872 100719 5000
Text mount 465 458 5000
TextField mount 1505 1497 5000
ThemeProvider mount 1279 1242 5000
ThemeProvider virtual-rerender 678 660 5000
ThemeProvider virtual-rerender-with-unmount 1981 2006 5000
Toggle mount 822 839 5000
buttonNative mount 131 124 5000

@ling1726 ling1726 merged commit 267e10e into microsoft:master Jun 28, 2022
rohitpagariya pushed a commit to rohitpagariya/fluentui that referenced this pull request Jun 28, 2022
@ling1726 @rohitpagariya
fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
ab97c64 
* fix: Dependency mismatch after 9.0.0 release

* changefile
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Jun 29, 2022
Merge branch 'master' into fix/dropdown-v8/narrator-announcing-incorr…
7675fbc 
…ect-amout-of-items

* master:
  chore: improve error message in useIsSSR() (microsoft#23750)
  fix: Codesandbox exports should use ^9.0.0 (microsoft#23764)
  applying package updates
  Update BadgeColor.stories.tsx (microsoft#23762)
  chore(react-avatar): Adding unit and vr tests for AvatarGroup (microsoft#23549)
  docs(react-avatar): Adding readme and migration guide for AvatarGroup (microsoft#23758)
  update deps after 9.0.1 release (microsoft#23756)
  applying package updates
  fix: Use caret dependency range for Griffel (microsoft#23754)
  Theme designer: minor fixes (microsoft#23741)
  fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@layershifter layershifter layershifter approved these changes

@GeoffCoxMSFT GeoffCoxMSFT GeoffCoxMSFT approved these changes

@spmonahan spmonahan spmonahan approved these changes

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
June Project Cycle Q2 2022
Development

Successfully merging this pull request may close these issues.
8 participants
@ling1726 @DustyTheBot @fabricteam @TristanWatanabe @layershifter @GeoffCoxMSFT @spmonahan @bsunderhus