Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(react-avatar): Adding readme and migration guide for AvatarGroup #23758

Merged
merged 2 commits into from
Jun 28, 2022
Merged

docs(react-avatar): Adding readme and migration guide for AvatarGroup #23758

merged 2 commits into from
Jun 28, 2022

Conversation

sopranopillow
Copy link
Contributor

This PR adds a readme and migration guide for AvatarGroup.

Related Issue(s)

#22240

@sopranopillow sopranopillow self-assigned this Jun 28, 2022
@sopranopillow sopranopillow requested review from a team, behowell and khmakoto as code owners June 28, 2022 22:03
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a8ec3e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar		 46.757 kB
13.737 kB
react-avatar
AvatarGroup		 136.183 kB
40.662 kB
react-avatar
AvatarGroupItem		 66.472 kB
19.079 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.067 kB
52.144 kB
react-components
react-components: FluentProvider & webLightTheme		 31.883 kB
10.516 kB
🤖 This report was generated against 2765b1f72c50c96e7f8e433d80762e9fa25d685f

@size-auditor
Copy link

size-auditor bot commented Jun 28, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2765b1f72c50c96e7f8e433d80762e9fa25d685f (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
MakeStyles mount 2458 2504 50000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1665 1705 5000
Button mount 1262 1221 5000
FluentProvider mount 2299 2314 5000
FluentProviderWithTheme mount 898 912 10
FluentProviderWithTheme virtual-rerender 831 815 10
FluentProviderWithTheme virtual-rerender-with-unmount 912 895 10
MakeStyles mount 2458 2504 50000 Possible regression

khmakoto
khmakoto approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@khmakoto khmakoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok for now, once we move the component to stable we should look at having a singular README for both Avatar and AvatarGroup in the react-avatar package root that points to the specs and migration guides of each (which by then should be probably moved to their respective component folders).

Can you make an issue tracking this follow-up work?

@sopranopillow
Copy link
Contributor Author

I think this is ok for now, once we move the component to stable we should look at having a singular README for both Avatar and AvatarGroup in the react-avatar package root that points to the specs and migration guides of each (which by then should be probably moved to their respective component folders).

Can you make an issue tracking this follow-up work?

Yes, that will be the next step once it's moved to stable. I'll add it to the epic to keep track of it.

@sopranopillow sopranopillow mentioned this pull request Jun 28, 2022
Closed
34 tasks
@sopranopillow sopranopillow merged commit dad21ca into microsoft:master Jun 28, 2022
@sopranopillow sopranopillow deleted the avatargroup-docs branch June 28, 2022 22:55
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Jun 29, 2022
Merge branch 'master' into fix/dropdown-v8/narrator-announcing-incorr…
7675fbc 
…ect-amout-of-items

* master:
  chore: improve error message in useIsSSR() (microsoft#23750)
  fix: Codesandbox exports should use ^9.0.0 (microsoft#23764)
  applying package updates
  Update BadgeColor.stories.tsx (microsoft#23762)
  chore(react-avatar): Adding unit and vr tests for AvatarGroup (microsoft#23549)
  docs(react-avatar): Adding readme and migration guide for AvatarGroup (microsoft#23758)
  update deps after 9.0.1 release (microsoft#23756)
  applying package updates
  fix: Use caret dependency range for Griffel (microsoft#23754)
  Theme designer: minor fixes (microsoft#23741)
  fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
khmakoto pushed a commit to khmakoto/fluentui that referenced this pull request Jul 13, 2022
@sopranopillow @khmakoto
docs(react-avatar): Adding readme and migration guide for AvatarGroup (…
98d5233 
…microsoft#23758)

* docs: Adding docs for AvatarGroup.

* change fileS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@behowell behowell Awaiting requested review from behowell

Assignees

@sopranopillow sopranopillow

Labels
Component: Avatar Component: AvatarGroup AvatarGroup component. Fluent UI react-components (v9)
Projects
@fluentui/react-components v9.0.0
Status: Done
Milestone
June Project Cycle Q2 2022
Development

Successfully merging this pull request may close these issues.
3 participants
@sopranopillow @fabricteam @khmakoto