Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust stacked bar chart styles as per design #25334

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Oct 21, 2022

Current Behavior

StackedBarChart (Before)

MultiStackedBarChart (Before)

New Behavior

StackedBarChart (After)

MultiStackedBarChart (After)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 21, 2022

📊 Bundle size report

🤖 This report was generated against a847f4059f4863a8d707f253b4a82f75855a3a89

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f39383d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a847f4059f4863a8d707f253b4a82f75855a3a89 (build)

@krkshitij krkshitij marked this pull request as ready for review October 24, 2022 10:36
@krkshitij krkshitij requested a review from a team as a code owner October 24, 2022 10:36
@@ -40,7 +40,7 @@ export interface IMultiStackedBarChartState {

export class MultiStackedBarChartBase extends React.Component<IMultiStackedBarChartProps, IMultiStackedBarChartState> {
public static defaultProps: Partial<IMultiStackedBarChartProps> = {
barHeight: 16,
barHeight: 12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the size of legend also need to be updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't find any guidance for legend size in the work item

@krkshitij krkshitij merged commit 52fb1e3 into microsoft:master Dec 5, 2022
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* adjust stacked bar chart styles as per design

* add change file

* minor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants