Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup wc v3 daily releases #25808

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Nov 28, 2022

New Behavior

  • removed all existing changefiles that came from master when branching out
  • new CI check to verify changefiles (will block PR if fails)

publish

  • new azure pipeline definition that will release WC only daily (mon-friday)

yarn change

  • runs against web-components-v3 branch
  • only prerelease change files are allowed and only for @fluentui/web-components
{
  "type": "prerelease",
  "comment": "hello change",
  "packageName": "@fluentui/web-components",
  "email": "martinhochel@microsoft.com",
  "dependentChangeType": "patch"
}

Release result

NOTE: I also tested releasing with those changefiles present to verify nothing will be bumped besideds web-components

1st changefile for web-components with type: prerelase will trigger following release changes:

dist-tag

every release will be available only under @alpha dist-tag

npm i @fluentui/web-components --> installs @latest which is 2.5.8

npm i @fluentui/web-components@alpha --> installs latest @alpha which - for example 3.0.0-alpha.1
npm i @fluentui/web-components@3.0.0-alpha.2 --> installs 3.0.0-alpha.2

Changelog.md

image

package.json

image

misc

  • removal of change files
  • updated CHANGELOG.json

Related Issue(s)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 28, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e48e679:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 28, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cd42ab4f8aa11c7ac134538193dc8dc4a01ca0f3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 28, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.153 kB
1.299 kB
react-accordion
Accordion (including children components)
79.243 kB
24.436 kB
react-alert
Alert
84.688 kB
21.233 kB
react-avatar
Avatar
48.874 kB
13.864 kB
react-avatar
AvatarGroup
14.996 kB
6.013 kB
react-avatar
AvatarGroupItem
63.452 kB
17.959 kB
react-badge
Badge
22.646 kB
7.228 kB
react-badge
CounterBadge
23.536 kB
7.512 kB
react-badge
PresenceBadge
24.096 kB
7.09 kB
react-button
Button
36.849 kB
9.907 kB
react-button
CompoundButton
43.874 kB
11.123 kB
react-button
MenuButton
39.543 kB
10.807 kB
react-button
SplitButton
46.989 kB
12.192 kB
react-button
ToggleButton
52.716 kB
11.381 kB
react-card
Card - All
67.664 kB
19.635 kB
react-card
Card
63.346 kB
18.539 kB
react-card
CardFooter
8.607 kB
3.622 kB
react-card
CardHeader
9.65 kB
3.962 kB
react-card
CardPreview
8.708 kB
3.678 kB
react-combobox
Combobox (including child components)
75.85 kB
24.632 kB
react-combobox
Dropdown (including child components)
75.579 kB
24.594 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-dialog
Dialog (including children components)
83.147 kB
24.799 kB
react-divider
Divider
16.505 kB
5.925 kB
react-image
Image
10.826 kB
4.286 kB
react-infobutton
InfoButton
7.742 kB
3.265 kB
react-input
Input
24.428 kB
7.899 kB
react-label
Label
9.384 kB
3.883 kB
react-link
Link
11.852 kB
4.888 kB
react-menu
Menu (including children components)
116.78 kB
36.112 kB
react-menu
Menu (including selectable components)
119.849 kB
36.635 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
53.992 kB
15.25 kB
react-popover
Popover
103.342 kB
31.82 kB
react-portal
Portal
10.628 kB
3.899 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.724 kB
7.415 kB
react-progress
Progress
13.131 kB
5.039 kB
react-provider
FluentProvider
15.807 kB
5.909 kB
react-radio
Radio
36.436 kB
12.126 kB
react-radio
RadioGroup
14.294 kB
5.723 kB
react-select
Select
23.255 kB
7.954 kB
react-slider
Slider
31.978 kB
10.149 kB
react-spinbutton
SpinButton
45.826 kB
12.858 kB
react-spinner
Spinner
20.023 kB
6.461 kB
react-switch
Switch
33.388 kB
10.578 kB
react-text
Text - Default
11.828 kB
4.627 kB
react-text
Text - Wrappers
15.138 kB
5.064 kB
react-textarea
Textarea
25.687 kB
8.331 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.65 kB
6.444 kB
react-theme
Teams: Light theme
17.486 kB
5.057 kB
react-tooltip
Tooltip
41.718 kB
14.687 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against cd42ab4f8aa11c7ac134538193dc8dc4a01ca0f3

@@ -13,7 +13,6 @@
"@fluentui/react": "^8.99.0",
"@fluentui/react-components": "^9.6.1",
"@fluentui/react-icons": "^2.0.175",
"@fluentui/web-components": "^2.5.8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing for wc3 branch ( v3 WC are not used here ). @miroslavstastny we could undo your commented code and use wc v2 from npm (would need tweaking of the stress-test setup ). Lemme know what do you wanna do. ty

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just forgot to remove the dependency. Let's remove for now.

- template: .devops/templates/variables.yml
parameters:
skipComponentGovernanceDetection: false
- name: release.web_components # Used to scope beachball to release only vnext packages
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably not needed - remove

@Hotell Hotell force-pushed the hotell/wc/setup-daily-alpha-releases branch from fe1dc69 to 01b0925 Compare November 30, 2022 10:58
@Hotell Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 30, 2022
@Hotell Hotell force-pushed the hotell/wc/setup-daily-alpha-releases branch from ad306e0 to e69a656 Compare November 30, 2022 11:33
@Hotell Hotell force-pushed the hotell/wc/setup-daily-alpha-releases branch from d495069 to ac2ab6d Compare November 30, 2022 13:49
@Hotell Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 30, 2022
@Hotell Hotell marked this pull request as ready for review November 30, 2022 18:00
@Hotell Hotell requested a review from a team as a code owner November 30, 2022 18:00
@tudorpopams tudorpopams self-requested a review December 1, 2022 13:15
@Hotell Hotell merged commit 7f15428 into microsoft:web-components-v3 Dec 2, 2022
@Hotell Hotell deleted the hotell/wc/setup-daily-alpha-releases branch December 2, 2022 09:16
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
chrisdholt pushed a commit that referenced this pull request Apr 29, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request Apr 30, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 2, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 2, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 2, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 3, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 6, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 6, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 8, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
radium-v pushed a commit that referenced this pull request May 10, 2024
* ci: setup wc v3 daily releases

* chore: UNDO - remove web-components from stress-test deps

* ci: add change files check so we dont accidentaly release something beside wc-3

* chore: remove changefiles from master that could trigger unwanted releases

* generate changefiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants