fix: Allow data-selection-disabled to be respected by DetailsRow #25836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khmakoto
added
Component: DetailsList
Fluent UI react (v8)
smhigley
approved these changes
Nov 29, 2022
Asset size changes
Baseline commit: 678f8db7fdb91324c5bcaa4e5e16cd36c8b70f3d (build) |
spmonahan
approved these changes
Nov 29, 2022
| @@ -327,7 +327,7 @@ export class DetailsRowBase extends React.Component<IDetailsRowBaseProps, IDetai | |||
| className={this._classNames.root} | |||
| data-selection-index={itemIndex} | |||
| data-selection-touch-invoke={true} | |||
| data-selection-disabled={disabled || undefined} | |||
| data-selection-disabled={(this.props as any)['data-selection-disabled'] ?? disabled ?? undefined} | |||
There was a problem hiding this comment.
This logic for this prop is getting more complex. Perhaps we should have a test or two?
| @@ -327,7 +327,7 @@ export class DetailsRowBase extends React.Component<IDetailsRowBaseProps, IDetai | |||
| className={this._classNames.root} | |||
| data-selection-index={itemIndex} | |||
| data-selection-touch-invoke={true} | |||
There was a problem hiding this comment.
Maybe this doesn't matter but it's also not possible for users to override this attribute. Seems similar to the one you changed.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 62c4af7:
|
📊 Bundle size report🤖 This report was generated against 678f8db7fdb91324c5bcaa4e5e16cd36c8b70f3d |
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 1039 screenshots✅ There was 1039 screenshots added, 0 screenshots removed, 0 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. OverflowSet.Root - RTL.default.chromium 1 screenshots
OverflowSet.Root.default.chromium 1 screenshots
SearchBox.Full - RTL.default.chromium 1 screenshots
SearchBox.Full.default.chromium 1 screenshots
SearchBox.Root - RTL.default.chromium 1 screenshots
SearchBox.Root.default.chromium 1 screenshots
SearchBox.ShowIcon - RTL.default.chromium 1 screenshots
SearchBox.ShowIcon.default.chromium 1 screenshots
unknown 1031 screenshots
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1422 | 1406 | 5000 | |
| Breadcrumb | mount | 3462 | 3437 | 1000 | |
| Checkbox | mount | 3094 | 3088 | 5000 | |
| CheckboxBase | mount | 2806 | 2771 | 5000 | |
| ChoiceGroup | mount | 5299 | 5284 | 5000 | |
| ComboBox | mount | 1455 | 1462 | 1000 | |
| CommandBar | mount | 11389 | 11258 | 1000 | |
| ContextualMenu | mount | 13181 | 13067 | 1000 | |
| DefaultButton | mount | 1626 | 1621 | 5000 | |
| DetailsRow | mount | 4380 | 4251 | 5000 | |
| DetailsRowFast | mount | 4318 | 4242 | 5000 | |
| DetailsRowNoStyles | mount | 4091 | 4129 | 5000 | |
| Dialog | mount | 3621 | 3695 | 1000 | |
| DocumentCardTitle | mount | 685 | 697 | 1000 | |
| Dropdown | mount | 3789 | 3785 | 5000 | |
| FocusTrapZone | mount | 2412 | 2415 | 5000 | |
| FocusZone | mount | 2368 | 2322 | 5000 | |
| GroupedList | mount | 2228 | 2545 | 2 | |
| GroupedList | virtual-rerender | 1331 | 1353 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1990 | 1939 | 2 | |
| GroupedListV2 | mount | 656 | 676 | 2 | |
| GroupedListV2 | virtual-rerender | 661 | 663 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 665 | 682 | 2 | |
| IconButton | mount | 2257 | 2276 | 5000 | |
| Label | mount | 874 | 884 | 5000 | |
| Layer | mount | 5125 | 5119 | 5000 | |
| Link | mount | 982 | 988 | 5000 | |
| MenuButton | mount | 1967 | 1956 | 5000 | |
| MessageBar | mount | 2783 | 2788 | 5000 | |
| Nav | mount | 3882 | 3890 | 1000 | |
| OverflowSet | mount | 1624 | 1606 | 5000 | |
| Panel | mount | 2995 | 2990 | 1000 | |
| Persona | mount | 1499 | 1567 | 1000 | |
| Pivot | mount | 1950 | 1946 | 1000 | |
| PrimaryButton | mount | 1790 | 1782 | 5000 | |
| Rating | mount | 8209 | 8304 | 5000 | |
| SearchBox | mount | 1777 | 1774 | 5000 | |
| Shimmer | mount | 3333 | 3339 | 5000 | |
| Slider | mount | 2417 | 2523 | 5000 | |
| SpinButton | mount | 5531 | 5442 | 5000 | |
| Spinner | mount | 954 | 954 | 5000 | |
| SplitButton | mount | 3654 | 3701 | 5000 | |
| Stack | mount | 972 | 981 | 5000 | |
| StackWithIntrinsicChildren | mount | 2860 | 2868 | 5000 | |
| StackWithTextChildren | mount | 5789 | 5798 | 5000 | |
| SwatchColorPicker | mount | 12363 | 12477 | 5000 | |
| TagPicker | mount | 3194 | 3083 | 5000 | |
| TeachingBubble | mount | 99362 | 98728 | 5000 | |
| Text | mount | 963 | 952 | 5000 | |
| TextField | mount | 1864 | 1928 | 5000 | |
| ThemeProvider | mount | 1810 | 1834 | 5000 | |
| ThemeProvider | virtual-rerender | 1258 | 1273 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2521 | 2550 | 5000 | |
| Toggle | mount | 1292 | 1315 | 5000 | |
| buttonNative | mount | 642 | 657 | 5000 |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Dec 1, 2022
* master: BREAKING: `useTable` renamed to `useTableFeatures` (microsoft#25797) chore: add retries for navigation in ssr-tests-v9 (microsoft#25844) fix: Cell actions should have correct background when row focused within (microsoft#25790) applying package updates Disable 3 Avatar Converged active stories (microsoft#25765) chore: introduce TS path aliases for improved DX in v8 (microsoft#25778) chore: prepare release react-northstar 0.65.0 (microsoft#25446) refactor(scripts): encapsulate v0 and v8 tooling within its domain boundaries (microsoft#25738) Support single point in area chart (microsoft#25842) chore: enable isolateModules in all v8 packages (microsoft#25774) chore: refactor styles for Button (microsoft#25216) feat: Improve docs for `DataGrid`, export as unstable (microsoft#25805) applying package updates fix: Allow data-selection-disabled to be respected by DetailsRow (microsoft#25836) docs(rfcs): Update recipes rfc with chosen option and add more details (microsoft#25823) chore(react-textarea): migrate to new package structure (microsoft#25820) chore(react-switch): migrate to new package structure (microsoft#25819) fix(react-avatar): AvatarGroup's pie layout places inline items correctly in rtl (microsoft#25822) chore: add few improvements to toolbar stories (microsoft#25635)
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…rosoft#25836) * fix: Allow data-selection-disabled to be respected by DetailsRow. * Adding change file. Co-authored-by: Humberto Makoto Morimoto Burgos <makotom@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Passing
data-selection-disabledtoDetailsRowwas being overridden by internal behavior.New Behavior
Passing
data-selection-disabledtoDetailsRowis now respected instead of being overridden by internal behavior.Related Issue(s)