-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): update web components swa workflow #26960
fix(ci): update web components swa workflow #26960
Conversation
update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger
@@ -1,6 +1,7 @@ | |||
name: Azure Static Web Apps web components | |||
|
|||
on: | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manual dispatch don't work if workflow doesn't exist in default branch ( in our case master ) - let's remove it to avoid confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing!
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ef8d441f59412e387c71ab3ae11ee967ad6ad5f8 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9fe83f8:
|
📊 Bundle size reportUnchanged fixtures
|
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
* fix(ci): update web components swa workflow update workflow add yarn as engine in package.json add engines section in web-components package.json remove engines section from web components package json fix output location remove run condition replace branch add manual trigger * remove workflow_dispatch directive * remove azure storage workflow for web components docsite
Previous Behavior
The static web apps workflow was failing because of some incorrect configured paths. It also didn't use the root
package.json
file in order to install everything usingyarn
.New Behavior
This PR fixes the workflow and deploys the storybook to a Static Web App ADO instance.