Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the keyboard accessibiilty bug in area chart on legend click #28515

Merged
merged 8 commits into from
Jul 25, 2023

Conversation

yush-singla
Copy link
Contributor

@yush-singla yush-singla commented Jul 13, 2023

Previous Behavior

  • Keyboard focus is not landing on the particular legend on graph when selecting the particular legend Option
  • The color of the vertical line in line chart didn't have the correct luminosity ratio (3:1)

New Behavior

  • Keyboard focus is landing on the particular legend on graph when selecting the particular legend Option
  • The color of the vertical line in the line chart has the correct luminosity ratio (3:1)
    image

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 13, 2023

📊 Bundle size report

🤖 This report was generated against b34f5f262efaeb8b1e16be2f4085a1576532ef13

@size-auditor
Copy link

size-auditor bot commented Jul 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b34f5f262efaeb8b1e16be2f4085a1576532ef13 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc51825:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@yush-singla yush-singla marked this pull request as ready for review July 13, 2023 12:46
@yush-singla yush-singla requested a review from a team as a code owner July 13, 2023 12:46
@AtishayMsft AtishayMsft merged commit 086cd4c into microsoft:master Jul 25, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants