fix(react-positioning): autoSize causing position update to reach maximum #28689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanboXue-Amber
changed the title
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 617 | 618 | 5000 | |
| Button | mount | 300 | 286 | 5000 | |
| Field | mount | 1059 | 1064 | 5000 | |
| FluentProvider | mount | 645 | 650 | 5000 | |
| FluentProviderWithTheme | mount | 86 | 78 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 70 | 73 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 84 | 10 | |
| InfoButton | mount | 15 | 11 | 5000 | |
| MakeStyles | mount | 851 | 828 | 50000 | |
| Persona | mount | 1696 | 1622 | 5000 | |
| SpinButton | mount | 1371 | 1285 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 889af91:
|
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 937b241d624114c181ea1521d0d4ead1068ddfa3 (build) |
fabricteam
reviewed
Jul 31, 2023
change/@fluentui-react-positioning-86dcd6cd-76f3-4f49-b446-04e827493aa7.json
Show resolved
Hide resolved
ling1726
approved these changes
Jul 31, 2023
layershifter
reviewed
Aug 1, 2023
packages/react-components/react-positioning/src/middleware/maxSize.test.ts
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Aug 1, 2023
packages/react-components/react-positioning/src/middleware/maxSize.test.ts
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Aug 1, 2023
packages/react-components/react-positioning/src/middleware/maxSize.test.ts
Show resolved
Hide resolved
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 1, 2023
* master: (37 commits) release (microsoft#28696) Fixing re-render issue for all charts when empty (microsoft#28321) feat(FluentProvider): emit errors on duplicate IDs (microsoft#28670) applying package updates fix(react-positioning): autoSize causing position update to reach maximum (microsoft#28689) fix(react-tags-preview): fix InteractionTag hover styles (microsoft#28686) Accordion: export AccordionHeaderProvider (microsoft#28542) feat(react-shared-contexts): add AnnounceContext (microsoft#28654) Added VR tests for Breadcrumb (microsoft#28653) fix(react-menu): use outline for menuItem focus ring (microsoft#28685) [Bug]: Tree, vertical spacing of branches and children is inconsistent (microsoft#28681) feaTt(react-tree): adds openItems and checkedItems to tree callback data (microsoft#28669) applying package updates Add mountNode prop to combos (microsoft#28661) react-tags-preview: add more vr test (microsoft#28582) chore: migrate to nx 16.1.4 (microsoft#28583) applying package updates chore: improves internal headless signature (microsoft#28651) fix: remove margin from icon when ToolbarButton is vertical (microsoft#28658) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28649 introduced
resetMaxSizemiddleware - whenautoSizeis specified,resetMaxSizemiddleware is used to reset the styles from previous life cycle and set a flag to not reset again. But the flag didn't work because of a stupid mistake in the check. This PR corrects it.