Fixed bug with inaccurate calc #28728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinaKozlova
force-pushed
the
fix/overflow-accurate-calculation
branch
from
bc17f57
to
f2e9a9f
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca01ebc:
|
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 67 | 78 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 631 | 629 | 5000 | |
| Button | mount | 319 | 296 | 5000 | |
| Field | mount | 1132 | 1143 | 5000 | |
| FluentProvider | mount | 666 | 665 | 5000 | |
| FluentProviderWithTheme | mount | 67 | 78 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 63 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 71 | 10 | |
| InfoButton | mount | 14 | 9 | 5000 | |
| MakeStyles | mount | 823 | 830 | 50000 | |
| Persona | mount | 1754 | 1742 | 5000 | |
| SpinButton | mount | 1388 | 1404 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 253798f25326e92ba19b313c47a9c9530af12526 (build) |
ValentinaKozlova
force-pushed
the
fix/overflow-accurate-calculation
branch
from
f2e9a9f
to
13e1223
Compare
ling1726
reviewed
Aug 4, 2023
packages/react-components/priority-overflow/src/overflowManager.ts
Outdated
Show resolved
Hide resolved
ling1726
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
[Bug]: Inaccurate calculation in Overflow #28727