-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(react-tags-preview): use JSX children instead of slots for InteractionTag's buttons #28739
Conversation
📊 Bundle size report🤖 This report was generated against d1a32c704b6901ceb3f976ad2148d8bbffc7628a |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ae5b24e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d1a32c704b6901ceb3f976ad2148d8bbffc7628a (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
...ages/react-components/react-tags-preview/src/components/InteractionTag/useInteractionTag.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags-preview/src/components/Secondary/Secondary.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags-preview/src/components/Tag/Tag.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags-preview/src/contexts/interactionTagContext.tsx
Show resolved
Hide resolved
packages/react-components/react-tags-preview/src/contexts/useAvatarContextValues.ts
Outdated
Show resolved
Hide resolved
…condary/Secondary.types.ts Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
Use JSX children for interactionTag's two buttons instead of slots.
Previous Behavior
New Behavior
JSX children provides an easier way to attach popover/tooltip to the primary/secondary button of InteractionTag. And this is one of the main use case we're targeting.