avatar unit tests #28800
Merged
avatar unit tests #28800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erbrady/fluentui-fork into web-components-v3
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
📊 Bundle size report🤖 This report was generated against c96ab181996ff35afdf4e0a4dbd05d4954beba59 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c96ab181996ff35afdf4e0a4dbd05d4954beba59 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b5a5617:
|
chrisdholt
reviewed
Aug 9, 2023
Comment on lines
38
to
46
| test('should render with custom initials based on the provided initials value', async () => { | ||
| await root.evaluate(node => { | ||
| node.innerHTML = /* html */ ` | ||
| <fluent-avatar initials="JD"></fluent-avatar> | ||
| `; | ||
| }); | ||
|
|
||
| await expect(element).toHaveText('JD'); | ||
| }); |
There was a problem hiding this comment.
I don't think this actually fully tests what we'd like to see. This does provide initials when initials are provided, but I think we should validate that something like a name of Julie Wright with custom initials provided of JJ would yeild, JJ.
There was a problem hiding this comment.
Both are probably worthwile but we should be specific, "When no name value is set" for the first, "When name value is set" for the second.
Comment on lines
48
to
56
| test('should set the size attribute to the provided size value', async () => { | ||
| await root.evaluate(node => { | ||
| node.innerHTML = /* html */ ` | ||
| <fluent-avatar size="48"></fluent-avatar> | ||
| `; | ||
| }); | ||
|
|
||
| await expect(element).toHaveAttribute('size', '48'); | ||
| }); |
There was a problem hiding this comment.
Should we test all? What about when size is updated, etc?
|
|
||
| await expect(element).toHaveAttribute('color', 'brand'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
What about active, using colorId, the this.color colorful portion (should that be tested for input/output)?
There was a problem hiding this comment.
I was having a heck of a time testing the color-id scenarios. Let me know what you think.
halerankin
approved these changes
Aug 15, 2023
…rianbrady/avatarUnitTests
miroslavstastny
approved these changes
Aug 24, 2023
miroslavstastny
merged commit 2c97f92
into
microsoft:web-components-v3
19 checks passed
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * avatar unit tests: adds tests * avatar tests: updates tests * avatar unit tests: updates tests * fix lint errors * fixes linting errors --------- Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Avatar unit tests