Add IconDirectionProvider to FluentProvider #28803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9757dc2:
|
bsunderhus
reviewed
Aug 10, 2023
packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx
Outdated
Show resolved
Hide resolved
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 71 | 61 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 622 | 603 | 5000 | |
| Button | mount | 307 | 320 | 5000 | |
| Field | mount | 1145 | 1142 | 5000 | |
| FluentProvider | mount | 670 | 676 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 71 | 61 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 69 | 10 | |
| InfoButton | mount | 10 | 9 | 5000 | |
| MakeStyles | mount | 855 | 866 | 50000 | |
| Persona | mount | 1680 | 1748 | 5000 | |
| SpinButton | mount | 1370 | 1334 | 5000 |
packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0c71b67bb41fdc2de8c3c547e77646a4b2ab36e9 (build) |
khmakoto
reviewed
Aug 17, 2023
khmakoto
previously approved these changes
Aug 17, 2023
...ct-components/react-provider/src/components/FluentProvider/useFluentProviderContextValues.ts
Outdated
Show resolved
Hide resolved
🕵 fluentuiv9 No visual regressions between this PR and main |
khmakoto
approved these changes
Aug 22, 2023
layershifter
approved these changes
Aug 28, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 29, 2023
* master: applying package updates feat: release react-motion as preview (microsoft#29005) fix(react-utilities): click scrollbar should invoke callback in `useOnClickOutside` (microsoft#28965) feat: adds mountNode to DialogSurface and Toaster (microsoft#29003) applying package updates Add IconDirectionProvider to FluentProvider (microsoft#28803)
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 29, 2023
* Add IconDirectionProvider * change file * update value provided to IconDirectionProvider * api update * code review comments * api update * Update iconDirection
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the
IconDirectionProviderto theFluentProviderin order to allow for default handling of rtl scenarios. TheIconDirectionContextValueis: