patch(react-table): expose DataGrid related contexts #28973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🕵 fluentuiv9 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 615 | 575 | 5000 | |
| Button | mount | 320 | 295 | 5000 | |
| Field | mount | 1094 | 1118 | 5000 | |
| FluentProvider | mount | 665 | 672 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 73 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 58 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 69 | 10 | |
| InfoButton | mount | 15 | 8 | 5000 | |
| MakeStyles | mount | 842 | 847 | 50000 | |
| Persona | mount | 1719 | 1658 | 5000 | |
| SpinButton | mount | 1299 | 1332 | 5000 |
FengQiMS
force-pushed
the
usr/fengqi/exposeDataGridrelatedcontext
branch
from
34d16be
to
ac1bfdf
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d216b7b:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f0afca3be87768300ce58c4629fbf135f23699ff (build) |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ling1726
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
useColumnIdContext,useIsInTableHeaderare not exposed from react-table, expose this let users implement their own datagrid header cell from primitives.New Behavior
useColumnIdContext,useIsInTableHeaderare exposed so that user can customize own DataGridHeaderCell to support different behaviour.