-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web-components): Fixed pathing to types for package exports #28986
fix(web-components): Fixed pathing to types for package exports #28986
Conversation
📊 Bundle size report🤖 This report was generated against 36ec4911bd318b6b59c2a0537611422c0f0a2e2e |
Hey @chrisdholt I never submitted a PR here, so I don't know what to do. When I build locally I am getting
|
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 36ec4911bd318b6b59c2a0537611422c0f0a2e2e (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9cb448d:
|
aa9831c
to
d8705b8
Compare
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder.
d8705b8
to
bf23274
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/Paste is a killer - thanks for this fix @mohamedmansour!
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
…osoft#28986) Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
…osoft#28986) Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
…osoft#28986) Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Running typescript typechecking threw an error that it cannot find the type for the import defined in the package exports. This change updates package.json to point to the right location, dts folder, instead of esm folder. Co-authored-by: Chris Holt <chhol@microsoft.com>
Previous Behavior
When typechecking a project that uses package exports, it is throwing an error:
New Behavior
The DTS should be correctly resolved since the package exports is pointing to the right one.