Adds Menu Component to sideEffects #29581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
approved these changes
Oct 18, 2023
📊 Bundle size report🤖 This report was generated against f2b0af056e0a4dd9e89fa3fbdb40a2f9b70186a3 |
fabricteam
reviewed
Oct 18, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Switch 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch.Checked - RTL.normal.chromium.png | 97 | Changed |
| Switch.Checked - RTL.hover.chromium.png | 104 | Changed |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f2b0af056e0a4dd9e89fa3fbdb40a2f9b70186a3 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 533df6a:
|
bearcat-msft
approved these changes
Oct 18, 2023
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* Adds menu component definition to list of sideEffects. * Generates change file. --------- Co-authored-by: Hale Rankin <hale.rankin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Menu web component definition was missing from the package.json sideEffects.
New Behavior
Menu web component definition is now included in the list of component definitions in package.json sideEffects.
Menu component is now properly exported.
Related Issue(s)