Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axe-core Integration into react-charting #2 #30139

Conversation

Shubhabrata08
Copy link
Contributor

@Shubhabrata08 Shubhabrata08 commented Dec 20, 2023

Previous Behavior

Axe-core accessibility tests present in AreaChart, LineChart, VerticalBarChart

New Behavior

Axe-core accessibility tests added to:

  1. DonutChart
  2. GroupedVerticalBarChart
  3. HorizontalbarChart
  4. HorizontalBarChartWithAxis
  5. StackedBarChart
  6. MultiStackedBarChart
  7. VerticalStackedBarChart

Related Issue(s)

  • Fixes #

Copy link

codesandbox-ci bot commented Dec 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c74791:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against b4844e599d85c9c135b8a0ea48d77c6d550b6b8f

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

Copy link

size-auditor bot commented Dec 21, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b4844e599d85c9c135b8a0ea48d77c6d550b6b8f (build)

@AtishayMsft AtishayMsft marked this pull request as ready for review December 21, 2023 17:37
@AtishayMsft AtishayMsft requested a review from a team as a code owner December 21, 2023 17:37
@AtishayMsft AtishayMsft merged commit a0d5e78 into microsoft:master Dec 21, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants