-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-components): revert syntax change for design tokens #30819
feat(web-components): revert syntax change for design tokens #30819
Conversation
📊 Bundle size reportUnchanged fixtures
|
change/@fluentui-web-components-518b3512-c7f4-4073-91e2-880c782b0864.json
Show resolved
Hide resolved
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
"comment": "revert design token syntax change for DX", | ||
"packageName": "@fluentui/web-components", | ||
"email": "=", | ||
"dependentChangeType": "patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be minor not patch right? If folks adopted the new behavior this is breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This specifically is for the dependentChangeType
, which I believe is for dependents in monorepos. The version will still use prerelease
, but I'm not aware of a way to force that to be minor
(agree it should). Using the CLI I can only specify prerelease
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustSlone @spmonahan I confirmed with Martin that we need to stay on the prerelease.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢ship it then? (maybe on Monday would be a good idea)
c5f5a2f
to
3880dc4
Compare
3880dc4
to
5089a1e
Compare
5089a1e
to
f9b9349
Compare
0bdcbe7
into
microsoft:web-components-v3
Co-authored-by: Christopher Holt <=>
…ft#30819) Co-authored-by: Christopher Holt <=>
…ft#30819) Co-authored-by: Christopher Holt <=>
…ft#30819) Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Co-authored-by: Christopher Holt <=>
Previous Behavior
This PR Reverts a previous change the the design token signature after feedback from multiple teams around the change. This ensures that the DX of using a token is both logical and convenient and doesn't require additional overhead from implementing teams.
New Behavior
The design tokens work as before the breaking change.
Related Issue(s)