Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-components): revert syntax change for design tokens #30819

Conversation

chrisdholt
Copy link
Member

Previous Behavior

This PR Reverts a previous change the the design token signature after feedback from multiple teams around the change. This ensures that the DX of using a token is both logical and convenient and doesn't require additional overhead from implementing teams.

New Behavior

The design tokens work as before the breaking change.

Related Issue(s)

  • Fixes #

@chrisdholt chrisdholt requested a review from a team as a code owner March 19, 2024 03:17
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 19, 2024

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
338 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.194 kB
1.315 kB
react-accordion
Accordion (including children components)
85.92 kB
25.987 kB
react-alert
Alert
89.744 kB
22.401 kB
react-avatar
Avatar
53.136 kB
14.785 kB
react-avatar
AvatarGroup
15.42 kB
6.138 kB
react-avatar
AvatarGroupItem
69.354 kB
19.078 kB
react-badge
Badge
23.78 kB
7.544 kB
react-badge
CounterBadge
24.67 kB
7.829 kB
react-badge
PresenceBadge
25.849 kB
7.546 kB
react-button
Button
36.883 kB
9.427 kB
react-button
CompoundButton
44.058 kB
10.9 kB
react-button
MenuButton
41.616 kB
10.787 kB
react-button
SplitButton
50.045 kB
12.351 kB
react-button
ToggleButton
55.247 kB
11.342 kB
react-card
Card - All
83.371 kB
23.931 kB
react-card
Card
78.14 kB
22.44 kB
react-card
CardFooter
9.04 kB
3.793 kB
react-card
CardHeader
10.979 kB
4.506 kB
react-card
CardPreview
9.847 kB
4.14 kB
react-checkbox
Checkbox
33.139 kB
10.361 kB
react-checkbox
CheckboxField
40.044 kB
12.241 kB
react-combobox
Combobox (including child components)
85.209 kB
27.263 kB
react-combobox
ComboboxField
81.626 kB
27.144 kB
react-combobox
Dropdown (including child components)
83.896 kB
27.025 kB
react-components
react-components: Button, FluentProvider & webLightTheme
64.085 kB
17.627 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
201.692 kB
56.275 kB
react-components
react-components: FluentProvider & webLightTheme
35.049 kB
11.612 kB
react-dialog
Dialog (including children components)
89.767 kB
26.682 kB
react-divider
Divider
17.105 kB
6.197 kB
react-field
Field
17.721 kB
6.563 kB
react-image
Image
11.259 kB
4.465 kB
react-infobutton
InfoButton
126.902 kB
38.72 kB
react-input
Input
24.848 kB
8.173 kB
react-input
InputField
35.106 kB
11.123 kB
react-label
Label
9.817 kB
4.059 kB
react-link
Link
12.306 kB
5.083 kB
react-menu
Menu (including children components)
126.252 kB
38.699 kB
react-menu
Menu (including selectable components)
129.321 kB
39.216 kB
react-overflow
hooks only
11.214 kB
4.247 kB
react-persona
Persona
59.974 kB
16.672 kB
react-popover
Popover
113.927 kB
35.085 kB
react-portal
Portal
11.377 kB
4.159 kB
react-portal-compat
PortalCompatProvider
6.324 kB
2.117 kB
react-positioning
usePositioning
22.857 kB
8.512 kB
react-progress
ProgressBar
13.573 kB
5.241 kB
react-progress
ProgressField
23.921 kB
8.394 kB
react-provider
FluentProvider
17.116 kB
6.334 kB
react-radio
Radio
32.724 kB
10.608 kB
react-radio
RadioGroup
14.885 kB
5.904 kB
react-radio
RadioGroupField
25.011 kB
9.086 kB
react-select
Select
24.193 kB
8.314 kB
react-select
SelectField
33.432 kB
10.811 kB
react-slider
Slider
33.086 kB
10.576 kB
react-slider
SliderField
42.97 kB
13.503 kB
react-spinbutton
SpinButton
45.232 kB
13.103 kB
react-spinbutton
SpinButtonField
54.495 kB
15.683 kB
react-spinner
Spinner
20.615 kB
6.69 kB
react-switch
Switch
28.273 kB
8.781 kB
react-switch
SwitchField
35.058 kB
10.663 kB
react-table
DataGrid
143.013 kB
39 kB
react-table
Table (Primitives only)
43.824 kB
12.084 kB
react-table
Table as DataGrid
134.338 kB
34.477 kB
react-table
Table (Selection only)
82.256 kB
20.562 kB
react-table
Table (Sort only)
81.685 kB
20.411 kB
react-text
Text - Default
12.261 kB
4.824 kB
react-text
Text - Wrappers
15.571 kB
5.245 kB
react-textarea
Textarea
26.331 kB
8.598 kB
react-textarea
TextareaField
36.585 kB
11.532 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
30.908 kB
6.725 kB
react-theme
Teams: Light theme
17.776 kB
5.144 kB
react-tooltip
Tooltip
45.962 kB
16.154 kB
react-utilities
SSRProvider
180 B
160 B
🤖 This report was generated against 9ac84d348585fbbb214b18be076c566ec60f9d99

Copy link

codesandbox-ci bot commented Mar 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@chrisdholt chrisdholt enabled auto-merge (squash) March 26, 2024 17:47
"comment": "revert design token syntax change for DX",
"packageName": "@fluentui/web-components",
"email": "=",
"dependentChangeType": "patch"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be minor not patch right? If folks adopted the new behavior this is breaking

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specifically is for the dependentChangeType, which I believe is for dependents in monorepos. The version will still use prerelease, but I'm not aware of a way to force that to be minor (agree it should). Using the CLI I can only specify prerelease.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustSlone @spmonahan I confirmed with Martin that we need to stay on the prerelease.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢ship it then? (maybe on Monday would be a good idea)

@chrisdholt chrisdholt force-pushed the users/chhol/revert-syntax-change-for-design-tokens branch from c5f5a2f to 3880dc4 Compare April 8, 2024 18:53
@chrisdholt chrisdholt force-pushed the users/chhol/revert-syntax-change-for-design-tokens branch from 3880dc4 to 5089a1e Compare April 8, 2024 19:04
@chrisdholt chrisdholt force-pushed the users/chhol/revert-syntax-change-for-design-tokens branch from 5089a1e to f9b9349 Compare April 8, 2024 19:10
@chrisdholt chrisdholt requested a review from a team as a code owner April 8, 2024 19:10
@chrisdholt chrisdholt merged commit 0bdcbe7 into microsoft:web-components-v3 Apr 8, 2024
16 of 17 checks passed
@chrisdholt chrisdholt deleted the users/chhol/revert-syntax-change-for-design-tokens branch April 8, 2024 21:35
chrisdholt added a commit that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
radium-v pushed a commit that referenced this pull request Apr 30, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 3, 2024
radium-v pushed a commit that referenced this pull request May 6, 2024
radium-v pushed a commit that referenced this pull request May 6, 2024
radium-v pushed a commit that referenced this pull request May 8, 2024
radium-v pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants