Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:(docs) - Adds type check to command cheat sheet #31411

Merged
merged 2 commits into from
May 17, 2024
Merged

chore:(docs) - Adds type check to command cheat sheet #31411

merged 2 commits into from
May 17, 2024

Conversation

mltejera
Copy link
Contributor

Adds type check command to cheat sheet.

@mltejera mltejera requested review from a team as code owners May 17, 2024 17:03
@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 621 636 5000
Button mount 310 303 5000
Field mount 1123 1117 5000
FluentProvider mount 731 728 5000
FluentProviderWithTheme mount 94 77 10
FluentProviderWithTheme virtual-rerender 31 37 10
FluentProviderWithTheme virtual-rerender-with-unmount 86 80 10
MakeStyles mount 944 907 50000
Persona mount 1797 1747 5000
SpinButton mount 1392 1387 5000
SwatchPicker mount 1597 1525 5000

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 17, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AvatarMinimalPerf.default 102 106 0.96:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 119 102 1.17:1
TreeWith60ListItems.default 94 81 1.16:1
FlexMinimalPerf.default 169 149 1.13:1
ButtonMinimalPerf.default 94 87 1.08:1
HeaderSlotsPerf.default 479 446 1.07:1
PortalMinimalPerf.default 89 83 1.07:1
CheckboxMinimalPerf.default 1168 1100 1.06:1
AnimationMinimalPerf.default 301 288 1.05:1
CarouselMinimalPerf.default 261 248 1.05:1
ChatDuplicateMessagesPerf.default 159 152 1.05:1
ListCommonPerf.default 410 392 1.05:1
TextMinimalPerf.default 206 197 1.05:1
ChatWithPopoverPerf.default 198 191 1.04:1
DividerMinimalPerf.default 207 199 1.04:1
InputMinimalPerf.default 553 533 1.04:1
SegmentMinimalPerf.default 204 196 1.04:1
BoxMinimalPerf.default 194 188 1.03:1
DropdownManyItemsPerf.default 402 389 1.03:1
HeaderMinimalPerf.default 210 204 1.03:1
ProviderMergeThemesPerf.default 657 637 1.03:1
SliderMinimalPerf.default 753 731 1.03:1
ChatMinimalPerf.default 439 430 1.02:1
DatepickerMinimalPerf.default 3564 3487 1.02:1
FormMinimalPerf.default 222 218 1.02:1
GridMinimalPerf.default 194 191 1.02:1
ItemLayoutMinimalPerf.default 701 685 1.02:1
LayoutMinimalPerf.default 204 200 1.02:1
MenuMinimalPerf.default 512 503 1.02:1
RosterPerf.default 1541 1506 1.02:1
ProviderMinimalPerf.default 200 197 1.02:1
ReactionMinimalPerf.default 213 208 1.02:1
CustomToolbarPrototype.default 1505 1469 1.02:1
TooltipMinimalPerf.default 1296 1267 1.02:1
TreeMinimalPerf.default 480 471 1.02:1
AttachmentMinimalPerf.default 80 79 1.01:1
DropdownMinimalPerf.default 1414 1404 1.01:1
ImageMinimalPerf.default 230 228 1.01:1
ListMinimalPerf.default 311 308 1.01:1
PopupMinimalPerf.default 347 345 1.01:1
SkeletonMinimalPerf.default 203 200 1.01:1
SplitButtonMinimalPerf.default 2233 2213 1.01:1
TableManyItemsPerf.default 1097 1084 1.01:1
ToolbarMinimalPerf.default 541 534 1.01:1
VideoMinimalPerf.default 448 443 1.01:1
AlertMinimalPerf.default 154 154 1:1
CardMinimalPerf.default 300 300 1:1
LabelMinimalPerf.default 214 213 1:1
ButtonOverridesMissPerf.default 645 653 0.99:1
ButtonSlotsPerf.default 313 316 0.99:1
EmbedMinimalPerf.default 1866 1887 0.99:1
ListNestedPerf.default 315 319 0.99:1
ListWith60ListItems.default 381 386 0.99:1
MenuButtonMinimalPerf.default 928 938 0.99:1
RadioGroupMinimalPerf.default 261 264 0.99:1
LoaderMinimalPerf.default 187 191 0.98:1
StatusMinimalPerf.default 389 398 0.98:1
TextAreaMinimalPerf.default 287 292 0.98:1
AttachmentSlotsPerf.default 630 648 0.97:1
DialogMinimalPerf.default 453 473 0.96:1
TableMinimalPerf.default 229 239 0.96:1
IconMinimalPerf.default 376 404 0.93:1
AccordionMinimalPerf.default 78 92 0.85:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 17, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 641 625 5000
Breadcrumb mount 1721 1703 1000
Checkbox mount 1752 1715 5000
CheckboxBase mount 1506 1494 5000
ChoiceGroup mount 3010 3002 5000
ComboBox mount 696 668 1000
CommandBar mount 6511 6485 1000
ContextualMenu mount 12843 12619 1000
DefaultButton mount 800 790 5000
DetailsRow mount 2247 2259 5000
DetailsRowFast mount 2262 2266 5000
DetailsRowNoStyles mount 2035 2039 5000
Dialog mount 2715 2720 1000
DocumentCardTitle mount 224 224 1000
Dropdown mount 2038 2023 5000
FocusTrapZone mount 1169 1137 5000
FocusZone mount 1080 1074 5000
GroupedList mount 42600 42716 2
GroupedList virtual-rerender 18204 20372 2
GroupedList virtual-rerender-with-unmount 51196 51111 2
GroupedListV2 mount 230 231 2
GroupedListV2 virtual-rerender 215 213 2
GroupedListV2 virtual-rerender-with-unmount 224 235 2
IconButton mount 1158 1131 5000
Label mount 332 353 5000
Layer mount 2762 2782 5000
Link mount 407 404 5000
MenuButton mount 964 998 5000
MessageBar mount 21473 21502 5000
Nav mount 2046 2021 1000
OverflowSet mount 818 811 5000
Panel mount 1840 1840 1000
Persona mount 739 725 1000
Pivot mount 906 880 1000
PrimaryButton mount 952 942 5000
Rating mount 4749 4742 5000
SearchBox mount 906 957 5000
Shimmer mount 1908 1887 5000
Slider mount 1385 1347 5000
SpinButton mount 3054 3016 5000
Spinner mount 393 404 5000
SplitButton mount 1925 1887 5000
Stack mount 422 414 5000
StackWithIntrinsicChildren mount 884 858 5000
StackWithTextChildren mount 2713 2693 5000
SwatchColorPicker mount 6453 6346 5000
TagPicker mount 1517 1463 5000
Text mount 385 367 5000
TextField mount 962 965 5000
ThemeProvider mount 844 867 5000
ThemeProvider virtual-rerender 590 601 5000
ThemeProvider virtual-rerender-with-unmount 1296 1311 5000
Toggle mount 610 617 5000
buttonNative mount 185 186 5000

@mltejera @sopranopillow
Update docs/react-v9/contributing/command-cheat-sheet.md
ceaea81 
Co-authored-by: Esteban Munoz Facusse <estebanmu@microsoft.com>
@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@mltejera mltejera merged commit f2aa169 into microsoft:master May 17, 2024
22 checks passed
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@mltejera @sopranopillow @miroslavstastny
chore:(docs) - Adds type check to command cheat sheet (microsoft#31411)
a12ac13 
Co-authored-by: Esteban Munoz Facusse <estebanmu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smhigley smhigley smhigley left review comments

@fabricteam fabricteam fabricteam left review comments

@sopranopillow sopranopillow sopranopillow approved these changes

@layershifter layershifter layershifter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mltejera @fabricteam @smhigley @sopranopillow @layershifter