Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: configure e2e target properly in order to make fix affected e2e target execution on ci #31685

Merged
merged 2 commits into from
Jun 13, 2024
Merged

ci: configure e2e target properly in order to make fix affected e2e target execution on ci #31685

merged 2 commits into from
Jun 13, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 12, 2024 •
edited
Loading

Previous Behavior

every PR CI run triggers all/non deterministic projects e2e and build-storybook target = --since doesn't work

Reproduction:

Following PR afffects only react-nav-preview

#31671

thought all projects that have e2e target are run 🐌 🐌 🐌 🐌

image

New Behavior

PR ci run triggers e2e and build-storybook target only on affected projects = --since works

Pipeline Perf boost:

PR containing package v9 changes

target Before After
e2e 399s 20s / 𝚫95% faster 🚅

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 12, 2024
@Hotell Hotell changed the title fix: configure e2e target properly in order to make fix affected e2e … fix: configure e2e target properly in order to make fix affected e2e target execution on ci Jun 12, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 12, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

Hotell
Hotell commented Jun 12, 2024
View reviewed changes
lage.config.js Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AlertMinimalPerf.default 152 145 1.05:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 118 101 1.17:1
RefMinimalPerf.default 121 105 1.15:1
FlexMinimalPerf.default 166 148 1.12:1
PortalMinimalPerf.default 93 85 1.09:1
MenuMinimalPerf.default 525 488 1.08:1
BoxMinimalPerf.default 203 191 1.06:1
ImageMinimalPerf.default 236 222 1.06:1
TableMinimalPerf.default 240 227 1.06:1
AnimationMinimalPerf.default 305 291 1.05:1
CarouselMinimalPerf.default 262 250 1.05:1
HeaderMinimalPerf.default 216 206 1.05:1
ListMinimalPerf.default 319 303 1.05:1
LoaderMinimalPerf.default 196 187 1.05:1
ReactionMinimalPerf.default 221 210 1.05:1
CardMinimalPerf.default 320 307 1.04:1
MenuButtonMinimalPerf.default 979 937 1.04:1
StatusMinimalPerf.default 395 380 1.04:1
TextMinimalPerf.default 197 190 1.04:1
GridMinimalPerf.default 196 191 1.03:1
RadioGroupMinimalPerf.default 274 266 1.03:1
ToolbarMinimalPerf.default 554 540 1.03:1
DividerMinimalPerf.default 200 196 1.02:1
ListCommonPerf.default 388 382 1.02:1
ListNestedPerf.default 320 313 1.02:1
PopupMinimalPerf.default 354 346 1.02:1
SkeletonMinimalPerf.default 206 201 1.02:1
SliderMinimalPerf.default 774 760 1.02:1
EmbedMinimalPerf.default 1891 1869 1.01:1
FormMinimalPerf.default 223 221 1.01:1
InputMinimalPerf.default 551 543 1.01:1
ListWith60ListItems.default 360 356 1.01:1
TableManyItemsPerf.default 1152 1141 1.01:1
TreeMinimalPerf.default 484 479 1.01:1
ButtonOverridesMissPerf.default 657 655 1:1
ButtonSlotsPerf.default 313 314 1:1
ChatMinimalPerf.default 444 444 1:1
CheckboxMinimalPerf.default 1146 1147 1:1
DropdownMinimalPerf.default 1443 1441 1:1
LayoutMinimalPerf.default 201 200 1:1
ProviderMergeThemesPerf.default 646 643 1:1
TextAreaMinimalPerf.default 294 293 1:1
TreeWith60ListItems.default 92 92 1:1
AccordionMinimalPerf.default 83 84 0.99:1
AttachmentMinimalPerf.default 79 80 0.99:1
ButtonMinimalPerf.default 92 93 0.99:1
DatepickerMinimalPerf.default 3677 3732 0.99:1
DialogMinimalPerf.default 441 446 0.99:1
LabelMinimalPerf.default 213 216 0.99:1
IconMinimalPerf.default 396 399 0.99:1
AttachmentSlotsPerf.default 648 660 0.98:1
ItemLayoutMinimalPerf.default 700 712 0.98:1
ProviderMinimalPerf.default 200 205 0.98:1
SplitButtonMinimalPerf.default 2243 2298 0.98:1
CustomToolbarPrototype.default 1447 1477 0.98:1
DropdownManyItemsPerf.default 390 401 0.97:1
TooltipMinimalPerf.default 1245 1277 0.97:1
RosterPerf.default 1517 1576 0.96:1
ChatWithPopoverPerf.default 192 202 0.95:1
HeaderSlotsPerf.default 450 475 0.95:1
ChatDuplicateMessagesPerf.default 154 164 0.94:1
VideoMinimalPerf.default 411 444 0.93:1
SegmentMinimalPerf.default 183 203 0.9:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 616 651 5000
Button mount 303 308 5000
Field mount 1153 1134 5000
FluentProvider mount 700 717 5000
FluentProviderWithTheme mount 83 88 10
FluentProviderWithTheme virtual-rerender 36 31 10
FluentProviderWithTheme virtual-rerender-with-unmount 79 74 10
MakeStyles mount 850 863 50000
Persona mount 1752 1723 5000
SpinButton mount 1409 1372 5000
SwatchPicker mount 1543 1557 5000

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 634 625 5000
Breadcrumb mount 1684 1691 1000
Checkbox mount 1738 1676 5000
CheckboxBase mount 1469 1475 5000
ChoiceGroup mount 2992 3000 5000
ComboBox mount 667 680 1000
CommandBar mount 6505 6450 1000
ContextualMenu mount 12388 12306 1000
DefaultButton mount 793 782 5000
DetailsRow mount 2256 2267 5000
DetailsRowFast mount 2207 2248 5000
DetailsRowNoStyles mount 2026 2032 5000
Dialog mount 2745 2660 1000
DocumentCardTitle mount 228 224 1000
Dropdown mount 1985 1993 5000
FocusTrapZone mount 1143 1159 5000
FocusZone mount 1090 1092 5000
GroupedList mount 41999 42299 2
GroupedList virtual-rerender 18063 20267 2
GroupedList virtual-rerender-with-unmount 51438 51100 2
GroupedListV2 mount 237 224 2
GroupedListV2 virtual-rerender 213 218 2
GroupedListV2 virtual-rerender-with-unmount 234 234 2
IconButton mount 1136 1131 5000
Label mount 339 340 5000
Layer mount 2745 2738 5000
Link mount 385 400 5000
MenuButton mount 1004 982 5000
MessageBar mount 21529 21541 5000
Nav mount 2081 2016 1000
OverflowSet mount 798 783 5000
Panel mount 1831 1834 1000
Persona mount 760 746 1000
Pivot mount 898 890 1000
PrimaryButton mount 916 924 5000
Rating mount 4631 4655 5000
SearchBox mount 929 947 5000
Shimmer mount 1924 1852 5000
Slider mount 1314 1327 5000
SpinButton mount 2966 2992 5000
Spinner mount 390 393 5000
SplitButton mount 1837 1891 5000
Stack mount 415 414 5000
StackWithIntrinsicChildren mount 853 882 5000
StackWithTextChildren mount 2648 2642 5000
SwatchColorPicker mount 6460 6319 5000
TagPicker mount 1432 1471 5000
Text mount 378 376 5000
TextField mount 926 962 5000
ThemeProvider mount 831 848 5000
ThemeProvider virtual-rerender 593 575 5000
ThemeProvider virtual-rerender-with-unmount 1277 1290 5000
Toggle mount 610 611 5000
buttonNative mount 201 189 5000

@Hotell Hotell marked this pull request as ready for review June 12, 2024 17:02
@Hotell Hotell requested review from a team as code owners June 12, 2024 17:02
@Hotell Hotell changed the title fix: configure e2e target properly in order to make fix affected e2e target execution on ci ci: configure e2e target properly in order to make fix affected e2e target execution on ci Jun 13, 2024
sopranopillow
sopranopillow approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@sopranopillow sopranopillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@Hotell Hotell merged commit e0ee62f into microsoft:master Jun 13, 2024
21 checks passed
@Hotell Hotell deleted the ci/perf/e2e-pipeline branch June 13, 2024 17:36
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
ci: configure e2e target properly in order to make fix affected e2e t…
bd12167 
…arget execution on ci (microsoft#31685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@sopranopillow sopranopillow sopranopillow approved these changes

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
Area: Build System Area: Performance CI
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @marcosmoura @sopranopillow