Website fix: Remove PureComponent #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As soon as we remove 0.14 support officially we can go back to enabling pure component usage. The better possibility is to make basecomponent support pure component. But this is a fine change for now. |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 6, 2018
* master: Applying package updates. Polyfill react create ref (microsoft#4182) [Pickers] Add async debounce option to BasePicker (microsoft#4163) Facepile conditionally rendering aria-describedby (microsoft#4183) Applying package updates. Addressing Issue microsoft#4174 - 5.59.0 crashing in <ImageBase> (microsoft#4185) Website fix: Remove PureComponent (microsoft#4186) Add Keytip and KeytipLayer to experiments export (microsoft#4184)
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Replaced PureComponent with Component * Added change file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Certain pages on the website weren't loading. PureComponent was not defined because the UHF in the website uses react 0.14. Switching to Component for now.
Focus areas to test
(optional)