-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking command support (BLPOP/BRPOP & BLMOVE) #356
Conversation
…oft/garnet into talzacc/blocking_list_ops
Please report BDN results of main vs. this branch for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments mostly related to allocations (both byte[] and Task) and potentially heavy code paths. We need to optimize for:
- The case where BL* instructions are not used (i.e., heavy classes are created lazily)
- Optional - avoid byte[] allocations by keeping items in FasterLog
- Avoid Task allocations by using the async codepath only when no items available to process synchronously.
current branch:
main:
|
Still remaining to address in this PR:
Added some website docs for the ItemBroker class here: website/docs/dev/collection-broker.md