Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle large writes in SendAndReset, adjust index default size #381

Merged
merged 7 commits into from
May 14, 2024

Conversation

badrishc
Copy link
Contributor

@badrishc badrishc commented May 14, 2024

Network Sends

  • Handle unexpected large writes in SendAndReset by throwing an exception so that the session can end gracefully
  • Support larger echo responses by splitting the response through a WriteDirectLarge wrapper

Index Defaults

  • Change default main store index size to 128m (optimized for up to ~8m distinct keys)
  • Change default object store index size to 16m (optimized for up to ~1m distinct keys)
  • Add logger informational message to indicate what the index is optimized for

Misc

  • Set CheckpointDir to LogDir (or current directory if LogDir is null) if CheckpointDir is not directly provided.

Fixes #380.

@badrishc badrishc requested a review from lmaas May 14, 2024 00:24
@badrishc badrishc changed the title Handle large writes in SendAndReset Handle large writes in SendAndReset, adjust index default size May 14, 2024
libs/server/Resp/RespServerSession.cs Dismissed Show dismissed Hide dismissed
libs/server/Resp/RespServerSession.cs Show resolved Hide resolved
libs/common/GarnetException.cs Show resolved Hide resolved
@badrishc badrishc merged commit 0bdc7a3 into main May 14, 2024
23 checks passed
@badrishc badrishc deleted the badrishc/handle-send-large-write branch May 14, 2024 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

100% mem and disk usage, when use "save" cmd
2 participants