Add stronger TLS check for Gossip in Cluster mode #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmaas
approved these changes
May 22, 2024
…a/enable_cert_validation_gossip
….com:microsoft/garnet into users/padgupta/enable_cert_validation_gossip
lmaas
reviewed
May 22, 2024
…a/enable_cert_validation_gossip
lmaas
approved these changes
May 23, 2024
chyin6
pushed a commit
to jusjin-org/garnet
that referenced
this pull request
Jul 2, 2024
* Add TLS cert validation when Garnet runs as client and does gossip * formatting fixes * add comment * address renaming concerns * fix whitespace and exception types * fix comment casing * added --------- Co-authored-by: Lukas Maas <lumaas@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #391.
It's a small change that uses ClusterTlsClientTargetHost and validates the incoming remote cert (during Gossip CLUSTER MEET call) and ensures that we're attempting to join a node that was created as part of current cluster setup. This can prevent issues of unknown clusters getting connected when multiple caches might be running in same IP pool. Previously, no such validation was there and we did an unconditional handshake approval (when ClientCertRequired is false). This will enforce the checks for only gossip where the server node acts as a client