Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure pre-serialized values are deleted after flush #65

Merged
merged 18 commits into from
Mar 27, 2024

Conversation

badrishc
Copy link
Contributor

@badrishc badrishc commented Mar 21, 2024

  • When we PostCopyUpdate an object, we replace the old image in the log with its serialized representation so that we have a consistent old version of the object. This PR optimizes this case to occur only during a snapshot checkpoint, because the (v) version needs to be captured only in that case.
  • The disk flush thread (either snapshot or head page flush) can pick up this serialized data for version (v) to write to disk.
  • We currently leave the serialized data intact in memory which causes heap to grow with repeated checkpoints. In this PR, we scan the log after the checkpoint to replace it with a null, in order to save on extra memory use.
  • Scan was extended to support scanning sealed records, as the serialized data is attached to the sealed records.
  • A subsequent snapshot can write Null to storage for this object, as we know the object is subsumed by a newer version thanks to the PCU.
  • Recovering from a checkpoint will reconstitute a null object, which is fine because a newer version of the object is known to exist.
  • This means we may now have null objects on the log - this is fine because Scan will always check for new version. We added support for a null object type in the serialized representation.

@badrishc badrishc marked this pull request as ready for review March 27, 2024 17:55
@badrishc badrishc merged commit cc9877b into main Mar 27, 2024
20 checks passed
@badrishc badrishc deleted the badrishc/obj-ser-fix branch March 27, 2024 22:34
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants