Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port changes from openssl-fips #51

Merged
merged 3 commits into from
May 11, 2023
Merged

Port changes from openssl-fips #51

merged 3 commits into from
May 11, 2023

Conversation

qmuntal
Copy link
Contributor

@qmuntal qmuntal commented May 8, 2023

This PR contains 3 commits ported from https://github.com/golang-fips/openssl-fips:

Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first port reminds me: I finally bit the bullet and added "files.eol": "\n", to my VS Code config recently. With the main Go repo rejecting autocrlf and other repos following that example, the safety will probably be nice.

// A BigInt is the raw words from a BigInt.
// This definition allows us to avoid importing math/big.
// Conversion between BigInt and *big.Int is in openssl/bbig.
type BigInt []uint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file showing up as a diff? Did the line endings change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I wanted to normalize it to \n, else it always shows as diff when vendoring the module in the Go toolchain.

@qmuntal qmuntal merged commit 35d7028 into main May 11, 2023
@qmuntal qmuntal deleted the leaks branch May 11, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants