Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removes unneeded receiver in timeoutError #223

Merged
merged 1 commit into from
Jul 14, 2022
Merged

chore: removes unneeded receiver in timeoutError #223

merged 1 commit into from
Jul 14, 2022

Conversation

jcchavezs
Copy link
Contributor

This PR removes receiver names from timeoutError as they aren't used.

@jcchavezs jcchavezs requested a review from a team as a code owner November 15, 2021 08:34
@dcantah
Copy link
Contributor

dcantah commented Nov 15, 2021

@jcchavezs Appreciate the PR! Could you sign off on your commit with git commit --amend -s and re-push? Change LGTM

@dcantah
Copy link
Contributor

dcantah commented Dec 2, 2021

ping @jcchavezs

@dcantah
Copy link
Contributor

dcantah commented Jul 13, 2022

Been awhile 😆 ping on this @jcchavezs

@jcchavezs
chore: removes unneeded receiver in timeoutError
4f8488c 
Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
@jcchavezs
Copy link
Contributor Author

Sorry for the delay. I just did it.

@helsaawy helsaawy self-assigned this Jul 14, 2022
@helsaawy helsaawy merged commit c62166d into microsoft:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@helsaawy helsaawy helsaawy approved these changes

Assignees

@helsaawy helsaawy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcchavezs @dcantah @helsaawy