Fix 'OpenVirtualDiskParameters' BOOL fields #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambarve
reviewed
Dec 1, 2021
ambarve
reviewed
Dec 1, 2021
While reworking the vhd package I'd mistakingly replaced some of the fields in the OpenVersion2 structure with the incorrect types. They're defined as Windows BOOLS which is just a type alias for an int, and I'd put their type as go bools. As the type is already passed into some functions, to avoid a breaking change just convert the incorrect type to a new structure with the correct definition internally. Truthfully this turns out a bit better as supplying a bool makes more sense and is more go friendly. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Change openVersion2 comment Signed-off-by: Daniel Canter <dcanter@microsoft.com>
|
@katiewasnothere PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reworking the vhd package I'd mistakingly replaced some of the fields
in the OpenVersion2 structure with the incorrect types. They're defined as
Windows BOOLS which is just a type alias for an int, and I'd put their type as
go bools.
As the type is already passed into some functions, to avoid a breaking change just
convert the incorrect type to a new structure with the correct definition internally.
Truthfully this turns out a bit better as supplying a bool makes more sense and is
more go friendly.
Signed-off-by: Daniel Canter dcanter@microsoft.com