Update mkwinsyscall and make stand alone tool #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied file from: https://github.com/golang/sys/blob/bc2c85ada10aa9b6aa9607e9ac9ad0761b95cf1d/windows/mkwinsyscall/mkwinsyscall.go Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Added hr error return type, cmdline flags for winio import, utf16, and sorting. Generated file has build constrain comment. Input files can be specified with a glob pattern. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
dcantah
reviewed
Jun 2, 2022
|
This is great that we're converging on one copy. Have you verified vendoring a local copy of winio with this change to hcsshim has everything work alright? |
None of the tests fail and the diffs dont look too egregious here: microsoft/hcsshim#1409. |
dcantah
reviewed
Jun 3, 2022
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
dcantah
approved these changes
Jun 3, 2022
anmaxvl
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
mkwinsyscallto latest version, and created a standalone tool that can be called from go-winio and hcsshim.Used latest version from:
https://github.com/golang/sys/blob/bc2c85ada10aa9b6aa9607e9ac9ad0761b95cf1d/windows/mkwinsyscall/mkwinsyscall.go
Applied changes from both
go-winio(forced UTF-16,go-winioimport) andhcsshim(UTF-16,HResulterror return type)Added (temporary?) flag to disable sorting so that generated syscall file diffs in hcsshim are easier to read.
Added build constraint comment to generated file, in case file names do not have one.
Allowed input files can be specified with a glob pattern.
This allows
hcsshim/internal/winapito avoid listing all the files within it://go:generate go run github.com/Microsoft/go-winio/tools/mkwinsyscall -output zsyscall_windows.go ./*.goPR has two commits so that changes can be rebased on newer versions of
golang.org/x/sys/windows/mkwinsyscall, but it may make more sense to create a dedicated branch on this repo with those commitsSigned-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com