/ go-winio Public
Update mkwinsyscall and make stand alone tool #248
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
mkwinsyscallto latest version, and created a standalone tool that can be called from go-winio and hcsshim.
Used latest version from:
Applied changes from both
HResulterror return type)
Added (temporary?) flag to disable sorting so that generated syscall file diffs in hcsshim are easier to read.
Added build constraint comment to generated file, in case file names do not have one.
Allowed input files can be specified with a glob pattern.
hcsshim/internal/winapito avoid listing all the files within it:
//go:generate go run github.com/Microsoft/go-winio/tools/mkwinsyscall -output zsyscall_windows.go ./*.go
PR has two commits so that changes can be rebased on newer versions of
golang.org/x/sys/windows/mkwinsyscall, but it may make more sense to create a dedicated branch on this repo with those commits
Signed-off-by: Hamza El-Saawy firstname.lastname@example.org