Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResolvePath tests #276

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Feb 7, 2023

Add required computestorage APIs to allow for running tests of ResolvePath.

Tests copied from containerd, introduced in this PR: containerd/containerd#5411

@helsaawy helsaawy force-pushed the fs-resolve-tests branch 2 times, most recently from ecdaf3e to 826c769 Compare April 6, 2023 17:51
@helsaawy helsaawy force-pushed the fs-resolve-tests branch 3 times, most recently from 46f1be8 to 466ea40 Compare April 14, 2023 19:26
Add required computestorage APIs to allow for running tests of
`ResolvePath`.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy marked this pull request as ready for review April 14, 2023 20:45
@helsaawy helsaawy requested a review from a team as a code owner April 14, 2023 20:45
Copy link
Contributor

@msscotb msscotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@helsaawy helsaawy merged commit 704d6c6 into microsoft:main Aug 3, 2023
@helsaawy helsaawy deleted the fs-resolve-tests branch August 3, 2023 16:10
helsaawy added a commit to helsaawy/go-winio that referenced this pull request Aug 3, 2023
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy added a commit that referenced this pull request Aug 3, 2023
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants