Switch openssl backend to golang-fips/openssl #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
a team and
microsoft-golang-review-bot
as code owners
dagood
reviewed
Jun 8, 2023
dagood
approved these changes
Jun 9, 2023
|
Is this going to be merged? It looks like it needs a rebase first. I also would want to update this to a newer snapshot of golang-fips/openssl to gain SHA3. |
I'm waiting for this to happen: golang-fips/openssl#83. I've stopped rebasing this PR till then, else I would have to rebase and fix conflicts constantly. |
qmuntal
force-pushed
the
dev/qmuntal/opensslfips
branch
from
36e9386
to
ce942fc
Compare
|
Waiting for golang-fips/openssl#92 |
qmuntal
force-pushed
the
dev/qmuntal/opensslfips
branch
from
860edc3
to
e46d895
Compare
chsienki
approved these changes
Jul 25, 2023
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
qmuntal
force-pushed
the
dev/qmuntal/opensslfips
branch
from
e46d895
to
b365422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/golang-fips/opensslis almost API-compatible withgithub.com/microsoft/go-crypto-openssl, so there are only a handful changes:openssl.DecryptRSAOAEPWithMGF1Hashandopenssl.EncryptRSAOAEPWithMGF1Hashare not defined, butopenssl.DecryptRSAOAEPandopenssl.EncryptRSAOAEPsupports the purpose of the former by adding an additional parameter.openssl.Initno longer supports OpenSSL version auto-selection, as it has too fork-specific. We have to implement the algorithm in our side instead.!androidbuild tag.