chore: add script for updating shorthands mappings #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
feat/shorthands-script
branch
from
86ce816
to
1197479
Compare
📊 Bundle size report🤖 This report was generated against 346e7246c24f068e97d115d8f897da825c26820d |
layershifter
force-pushed
the
feat/shorthands-script
branch
2 times, most recently
from
b83ce8d
to
2335b78
Compare
layershifter
force-pushed
the
feat/shorthands-script
branch
from
2335b78
to
f1b3418
Compare
ling1726
reviewed
Apr 23, 2024
| export function assignShorthandPriority(shorthandProperties: CSSShorthands): CSSShorthands { | ||
| const propertiesWithPriority = { ...shorthandProperties }; | ||
|
|
||
| Object.keys(shorthandProperties) |
There was a problem hiding this comment.
maybe assign the default -1 priorities in this function? The fact that the default priorities were assigned in the filter function confused me
There was a problem hiding this comment.
Makes sense, will redo it.
ling1726
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script that generates
packages/core/src/runtime/shorthands.ts. The file will contain a mapping of CSS shorthands to their longhands with priorities. That mapping is need to generate style resets that will remove longhands, see #531.