Rework merkle tree implementation to use io.Reader instead of byte array #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
force-pushed
the
merkle-tree-with-io-reader
branch
from
b3a2950
to
44d0864
Compare
|
FYI @SeanTAllen |
anmaxvl
force-pushed
the
merkle-tree-with-io-reader
branch
from
44d0864
to
9cce66a
Compare
dcantah
reviewed
Oct 27, 2021
|
Planning to look at this later today |
kevpar
reviewed
Oct 27, 2021
kevpar
reviewed
Oct 27, 2021
dcantah
reviewed
Oct 28, 2021
dcantah
reviewed
Oct 28, 2021
dcantah
reviewed
Oct 28, 2021
anmaxvl
force-pushed
the
merkle-tree-with-io-reader
branch
from
5f71418
to
4d2e604
Compare
|
@dcantah up 😄, @microsoft/containerplat more eyes are welcome |
msscotb
reviewed
Nov 3, 2021
anmaxvl
force-pushed
the
merkle-tree-with-io-reader
branch
2 times, most recently
from
fe6df3b
to
378b9d7
Compare
dcantah
reviewed
Nov 5, 2021
MerkleTree implementation requires the entire content of ext4 file system to be read into a byte array when computing cryptographic digest. This PR reworks the existing implementation to work with io.Reader interface instead. Additionally update the existing usages of MerkleTree with the new MerkleTreeWithReader implementation. Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
Separate tar to ext4 logic of Convert into a ConvertTarToExt4 function. Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
merkle-tree-with-io-reader
branch
from
378b9d7
to
a02bdf5
Compare
|
awesome |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MerkleTree implementation requires the entire content of ext4 file
system to be read into a byte array when computing cryptographic digest.
This PR reworks the existing implementation to work with io.Reader
interface instead.
Additionally update the existing usages of MerkleTree with the new
MerkleTreeWithReader implementation.
Signed-off-by: Maksim An maksiman@microsoft.com