Add 21H2 definitions to osversion package #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
osversion-21h2
branch
from
4ed154a
to
8b08804
Compare
anmaxvl
approved these changes
Oct 22, 2021
|
@kevpar Assigning you as we'd talked on ways to handle this. Now that the build number for the Windows 10 release is known, I've went with a prefix approach. Let me know if this looks sound. |
|
@kevpar ptal if you have some time |
This change adds three new definitions to the osversion package. All three definitions are all of the 21H2 builds across Windows 10, Windows Server and Windows 11, which all have different build numbers. The approach taken was to prefix the definitions with Win10, WinServer and Win11 respectively. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
osversion-21h2
branch
2 times, most recently
from
eb41aaa
to
5b0de38
Compare
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
osversion-21h2
branch
from
5b0de38
to
3809b8e
Compare
|
@ambarve Added your suggestion for naming, ptal |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 10, 2022
* Add 21H2 definitions to osversion package This change adds three new definitions to the osversion package. All three definitions are all of the 21H2 builds across Windows 10, Windows Server and Windows 11, which all have different build numbers. The approach taken was to add a suffix to the definitions with Win10, Server and Win11 respectively. Signed-off-by: Daniel Canter <dcanter@microsoft.com> (cherry picked from commit 3a8cd1e) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds three new definitions to the osversion package. All
three definitions are all of the 21H2 builds across Windows 10, Windows Server
and Windows 11, which all have different build numbers.
The approach taken was to prefix the definitions with Win10, WinServer and
Win11 respectively.
Signed-off-by: Daniel Canter dcanter@microsoft.com