Extend integrity protection of LCOW layers to SCSI devices #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeanTAllen as well |
anmaxvl
force-pushed
the
scsi-dm-verity
branch
3 times, most recently
from
9add2cc
to
671b03e
Compare
|
@anmaxvl I think what I am going to bring up can be done in another PR. It would be very easy at the code level to accidentally turn off dm-verity setup. Take for example, my not turning it on (inadvertently) in the previous SCSI PR that led to this being its own PR. I think our best "simple" approach at the unit test level would be to have an interface for device mapper actions that setup verity and have a test that fails if we don't get a "signal" of some sort from our test stand-in for device mapping. It's far from perfect but would give some level of check at unit test time that code wasn't inadvertently removed. Whatever we do for an approach, we should do for pmem as well. |
anmaxvl
force-pushed
the
scsi-dm-verity
branch
3 times, most recently
from
e0166f2
to
bb1be10
Compare
anmaxvl
changed the title
anmaxvl
force-pushed
the
scsi-dm-verity
branch
from
bb1be10
to
354aa1b
Compare
dcantah
reviewed
Oct 7, 2021
dcantah
reviewed
Oct 7, 2021
dcantah
reviewed
Oct 7, 2021
LCOW layers can be added both as VPMem and as SCSI devices. Previous work focused on enabling integrity protection for read only VPMem layers, this change enables it for read-only SCSI devices as well. Just like in a VPMem scenario, create dm-verity target when verity information is presented to the guest during SCSI device mounting step. Additionally remove unnecessary unit test, since the guest logic has changed. Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
scsi-dm-verity
branch
from
354aa1b
to
be898fa
Compare
Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
scsi-dm-verity
branch
from
be898fa
to
49e4ed6
Compare
dcantah
reviewed
Oct 7, 2021
dcantah
reviewed
Oct 7, 2021
SeanTAllen
reviewed
Oct 8, 2021
Comment on lines
+28
to
+30
| createZeroSectorLinearTarget = dm.CreateZeroSectorLinearTarget | ||
| createVerityTarget = dm.CreateVerityTarget | ||
| removeDevice = dm.RemoveDevice |
There was a problem hiding this comment.
so, what's the reasoning behind doing this? i found it somewhat confusing and harder to follow what was going on because of this. What is gained by doing this? Testability?
There was a problem hiding this comment.
yes, I added some tests to make sure that the device mapper targets are cleaned up on failure.
|
@dcantah please revisit 😄 |
Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
scsi-dm-verity
branch
from
5fdf004
to
adfcb48
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…#1170) * extend integrity protection of LCOW layers to SCSI devices LCOW layers can be added both as VPMem and as SCSI devices. Previous work focused on enabling integrity protection for read only VPMem layers, this change enables it for read-only SCSI devices as well. Just like in a VPMem scenario, create dm-verity target when verity information is presented to the guest during SCSI device mounting step. Additionally remove unnecessary unit test, since the guest logic has changed. Add pmem and scsi unit tests for linear/verity device mapper targets Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LCOW layers can be added both as VPMem and as SCSI devices.
Previous work focused on enabling integrity protection for read
only VPMem layers, this change enables it for read-only SCSI
devices as well.
Just like in a VPMem scenario, create dm-verity target when
verity information is presented to the guest during SCSI device
mounting step.
Additionally remove unnecessary unit test, since the guest logic
has changed.
Signed-off-by: Maksim An maksiman@microsoft.com