Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Bump ttrpc to 1.1.0 #1223

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

dcantah
Copy link
Contributor

@dcantah dcantah commented Nov 9, 2021

This tag contains a fix for a deadlock we'd observed on Windows when multiple
requests were made in parallel. containerd/ttrpc#94

@dcantah dcantah requested a review from a team as a code owner November 9, 2021 22:19
@kevpar
Copy link
Member

kevpar commented Nov 9, 2021

Nit: Usually would not use square brackets in the title here. Just do something like go.mod: Bump ttrpc to 1.1.0.

@kevpar
Copy link
Member

kevpar commented Nov 9, 2021

I assume you'll be doing a PR for release/0.8 as well?

@dcantah dcantah changed the title [go.mod] Bump ttrpc to 1.1.0 go.mod: Bump ttrpc to 1.1.0 Nov 9, 2021
@dcantah
Copy link
Contributor Author

dcantah commented Nov 9, 2021

@kevpar Yep! And the pr title was actually me brain farting what I was going to use as the release/0.8 pr title
[release/0.8] go.mod: Bump ttrpc to 1.1.0

This tag contains a fix for a deadlock we'd observed on Windows when multiple
requests were made in parallel.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah
Copy link
Contributor Author

dcantah commented Nov 9, 2021

No changes in latest push, just changing the commit title to have no brackets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants