HCS fixes for HclEnabled and guest state file type. #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Gordon <Ken.Gordon@microsoft.com>
… type. Signed-off-by: Ken Gordon <Ken.Gordon@microsoft.com>
Done. |
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* HclEnabled is required or it SEEMS to work but the vmgs gets written on. * Match the regular code - adds HclEnabled and correct guest state file type. Signed-off-by: Ken Gordon <Ken.Gordon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both required due to evolution of the hcs/vmms layers.
This PR replaces #1232 (GuestStateFileType=BlockStorage) which had trouble with signing and so passing the CI. In addition it sets the HclEnabled flag which is required or the vmgs file is corrupted by the vmms leading to the UVM only starting exactly once.
Signed-off-by: Ken Gordon Ken.Gordon@microsoft.com